From patchwork Wed Feb 27 12:10:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmytro Linkin X-Patchwork-Id: 1048862 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 448ZJp6F5Dz9s4Y for ; Wed, 27 Feb 2019 23:10:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730020AbfB0MKt (ORCPT ); Wed, 27 Feb 2019 07:10:49 -0500 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:53613 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729986AbfB0MKt (ORCPT ); Wed, 27 Feb 2019 07:10:49 -0500 Received: from Internal Mail-Server by MTLPINE1 (envelope-from dmitrolin@mellanox.com) with ESMTPS (AES256-SHA encrypted); 27 Feb 2019 14:10:43 +0200 Received: from dev-r-vrt-112.mtr.labs.mlnx. (dev-r-vrt-112.mtr.labs.mlnx [10.212.112.1]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x1RCAgTF030164; Wed, 27 Feb 2019 14:10:42 +0200 From: Dmytro Linkin To: netdev@vger.kernel.org Cc: Dmytro Linkin Subject: [iproute2] tc/pedit: Fix wrong pedit ipv6 structure id Date: Wed, 27 Feb 2019 12:10:17 +0000 Message-Id: <20190227121017.4244-1-dmitrolin@mellanox.com> X-Mailer: git-send-email 2.13.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tc pedit action with more than two ip6 munge in a row cause infinite loop. Example: $ tc filter add dev eth0 protocol ipv6 parent ffff: \ flower ip_proto sctp \ action pedit ex \ munge ip6 hoplimit set 0x1 \ munge ip6 src set 2001:0db8:0:f101::1 \ munge that cause infinite loop The example command never returns, instead of failing with parse error as expected. Pedit ipv6 structure has wrong id, which leads to the creation linked list with one node in tc/m_pedit.c:get_pedit_kind(), referring to itself. This node is created if command have two ip6 munge in a row, and any third ip6 munge will cause infinite loop. Changing this id from "ipv6" to "ip6" solves the problem. Fixes: f3e1b2448a95 ("pedit: Introduce ipv6 support") Signed-off-by: Dmytro Linkin Reviewed-by: Roi Dayan --- tc/p_ip6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tc/p_ip6.c b/tc/p_ip6.c index dbfdca42..7cc7997b 100644 --- a/tc/p_ip6.c +++ b/tc/p_ip6.c @@ -84,6 +84,6 @@ done: } struct m_pedit_util p_pedit_ip6 = { - .id = "ipv6", + .id = "ip6", .parse_peopt = parse_ip6, };