diff mbox series

[net-next] kcm: Remove unnecessary SLAB_PANIC for kmem_cache_create() in kcm_init

Message ID 20190222061530.9820-1-yuehaibing@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next] kcm: Remove unnecessary SLAB_PANIC for kmem_cache_create() in kcm_init | expand

Commit Message

Yue Haibing Feb. 22, 2019, 6:15 a.m. UTC 
From: YueHaibing <yuehaibing@huawei.com>

There has check NULL on kmem_cache_create on failure in kcm_init,
no need use SLAB_PANIC to panic the system.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 net/kcm/kcmsock.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Miller Feb. 23, 2019, 9:46 p.m. UTC | #1 
From: Yue Haibing <yuehaibing@huawei.com>
Date: Fri, 22 Feb 2019 14:15:30 +0800

> From: YueHaibing <yuehaibing@huawei.com>
> 
> There has check NULL on kmem_cache_create on failure in kcm_init,
> no need use SLAB_PANIC to panic the system.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

I'll apply this, thank you.
diff mbox series

Patch

diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c
index 571d824..c5c5ab6 100644
--- a/net/kcm/kcmsock.c
+++ b/net/kcm/kcmsock.c
@@ -2036,13 +2036,13 @@  static int __init kcm_init(void)
 
 	kcm_muxp = kmem_cache_create("kcm_mux_cache",
 				     sizeof(struct kcm_mux), 0,
-				     SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL);
+				     SLAB_HWCACHE_ALIGN, NULL);
 	if (!kcm_muxp)
 		goto fail;
 
 	kcm_psockp = kmem_cache_create("kcm_psock_cache",
 				       sizeof(struct kcm_psock), 0,
-					SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL);
+					SLAB_HWCACHE_ALIGN, NULL);
 	if (!kcm_psockp)
 		goto fail;