diff mbox series

[net-next] rocker: Add missing break for PRE_BRIDGE_FLAGS

Message ID 20190222022647.20144-1-f.fainelli@gmail.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next] rocker: Add missing break for PRE_BRIDGE_FLAGS | expand

Commit Message

Florian Fainelli Feb. 22, 2019, 2:26 a.m. UTC
A missing break keyword should have been added after adding support for
PRE_BRIDGE_FLAGS.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 93700458ff63 ("rocker: Check Handle PORT_PRE_BRIDGE_FLAGS")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/ethernet/rocker/rocker_main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Miller Feb. 22, 2019, 5:29 a.m. UTC | #1
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 21 Feb 2019 18:26:46 -0800

> A missing break keyword should have been added after adding support for
> PRE_BRIDGE_FLAGS.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 93700458ff63 ("rocker: Check Handle PORT_PRE_BRIDGE_FLAGS")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied.

This turned out to be a really rough series for your Florian :-) :-)
diff mbox series

Patch

diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index 8200fbf91306..309a6bf9130c 100644
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c
@@ -2083,6 +2083,7 @@  static int rocker_port_attr_set(struct net_device *dev,
 		err = rocker_world_port_attr_pre_bridge_flags_set(rocker_port,
 							      attr->u.brport_flags,
 							      trans);
+		break;
 	case SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS:
 		err = rocker_world_port_attr_bridge_flags_set(rocker_port,
 							      attr->u.brport_flags,