| Message ID | 20190211125426.21072-1-alban@kinvolk.io |
|---|---|
| State | Changes Requested |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | bpf: bpftool, fix documentation for attach types | expand |
2019-02-11 13:54 UTC+0100 ~ Alban Crequy <alban.crequy@gmail.com> > From: Alban Crequy <alban@kinvolk.io> > > bpftool has support for attach types "stream_verdict" and > "stream_parser" but the documentation was referring to them with > "skb_verdict" and "skb_parse". The inconsistency comes from commit > b7d3826c2ed6 ("bpf: bpftool, add support for attaching programs to > maps"). > > This patch changes the documentation to match the implementation. > > Signed-off-by: Alban Crequy <alban@kinvolk.io> > --- > tools/bpf/bpftool/prog.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c > index 0640e9bc0ada..dfaa019a60f0 100644 > --- a/tools/bpf/bpftool/prog.c > +++ b/tools/bpf/bpftool/prog.c > @@ -1198,7 +1198,7 @@ static int do_help(int argc, char **argv) > " cgroup/bind4 | cgroup/bind6 | cgroup/post_bind4 |\n" > " cgroup/post_bind6 | cgroup/connect4 | cgroup/connect6 |\n" > " cgroup/sendmsg4 | cgroup/sendmsg6 }\n" > - " ATTACH_TYPE := { msg_verdict | skb_verdict | skb_parse |\n" > + " ATTACH_TYPE := { msg_verdict | stream_verdict | stream_parser |\n" > " flow_dissector }\n" > " " HELP_SPEC_OPTIONS "\n" > "", > Thanks Alban! Could you please fix the man page and the bash completion file at the same time? Quentin
On Mon, Feb 11, 2019 at 2:26 PM Quentin Monnet <quentin.monnet@netronome.com> wrote: > > 2019-02-11 13:54 UTC+0100 ~ Alban Crequy <alban.crequy@gmail.com> > > From: Alban Crequy <alban@kinvolk.io> > > > > bpftool has support for attach types "stream_verdict" and > > "stream_parser" but the documentation was referring to them with > > "skb_verdict" and "skb_parse". The inconsistency comes from commit > > b7d3826c2ed6 ("bpf: bpftool, add support for attaching programs to > > maps"). > > > > This patch changes the documentation to match the implementation. > > > > Signed-off-by: Alban Crequy <alban@kinvolk.io> > > --- > > tools/bpf/bpftool/prog.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c > > index 0640e9bc0ada..dfaa019a60f0 100644 > > --- a/tools/bpf/bpftool/prog.c > > +++ b/tools/bpf/bpftool/prog.c > > @@ -1198,7 +1198,7 @@ static int do_help(int argc, char **argv) > > " cgroup/bind4 | cgroup/bind6 | cgroup/post_bind4 |\n" > > " cgroup/post_bind6 | cgroup/connect4 | cgroup/connect6 |\n" > > " cgroup/sendmsg4 | cgroup/sendmsg6 }\n" > > - " ATTACH_TYPE := { msg_verdict | skb_verdict | skb_parse |\n" > > + " ATTACH_TYPE := { msg_verdict | stream_verdict | stream_parser |\n" > > " flow_dissector }\n" > > " " HELP_SPEC_OPTIONS "\n" > > "", > > > > Thanks Alban! > > Could you please fix the man page and the bash completion file at the > same time? Yes, I will do that soon. Sorry for the delay in replying. Thanks, Alban
diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c index 0640e9bc0ada..dfaa019a60f0 100644 --- a/tools/bpf/bpftool/prog.c +++ b/tools/bpf/bpftool/prog.c @@ -1198,7 +1198,7 @@ static int do_help(int argc, char **argv) " cgroup/bind4 | cgroup/bind6 | cgroup/post_bind4 |\n" " cgroup/post_bind6 | cgroup/connect4 | cgroup/connect6 |\n" " cgroup/sendmsg4 | cgroup/sendmsg6 }\n" - " ATTACH_TYPE := { msg_verdict | skb_verdict | skb_parse |\n" + " ATTACH_TYPE := { msg_verdict | stream_verdict | stream_parser |\n" " flow_dissector }\n" " " HELP_SPEC_OPTIONS "\n" "",