Message ID | 20190209031611.1102-2-jakub.kicinski@netronome.com |
---|---|
State | Superseded |
Delegated to: | David Miller |
Headers | show |
Series | devlink: minor tweaks to reported device info | expand |
Sat, Feb 09, 2019 at 04:16:08AM CET, jakub.kicinski@netronome.com wrote: >We need the port to be both ethernet and have the rigth netdev, >not one or the other. > >Fixes: ddb6e99e2db1 ("ethtool: add compat for devlink info") >Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Acked-by: Jiri Pirko <jiri@mellanox.com>
diff --git a/net/core/devlink.c b/net/core/devlink.c index e6a015b8ac9b..cf0f511bc56c 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -6385,7 +6385,7 @@ void devlink_compat_running_version(struct net_device *dev, list_for_each_entry(devlink, &devlink_list, list) { mutex_lock(&devlink->lock); list_for_each_entry(devlink_port, &devlink->port_list, list) { - if (devlink_port->type == DEVLINK_PORT_TYPE_ETH || + if (devlink_port->type == DEVLINK_PORT_TYPE_ETH && devlink_port->type_dev == dev) { __devlink_compat_running_version(devlink, buf, len);
We need the port to be both ethernet and have the rigth netdev, not one or the other. Fixes: ddb6e99e2db1 ("ethtool: add compat for devlink info") Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> --- net/core/devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)