From patchwork Wed Feb 6 22:43:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Chopra X-Patchwork-Id: 1037779 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=marvell.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43vxPY0PV7z9sNH for ; Thu, 7 Feb 2019 09:46:09 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726600AbfBFWqH (ORCPT ); Wed, 6 Feb 2019 17:46:07 -0500 Received: from mail-eopbgr730066.outbound.protection.outlook.com ([40.107.73.66]:36414 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725959AbfBFWqH (ORCPT ); Wed, 6 Feb 2019 17:46:07 -0500 Received: from BYAPR07CA0046.namprd07.prod.outlook.com (2603:10b6:a03:60::23) by MWHPR07MB2909.namprd07.prod.outlook.com (2603:10b6:300:1e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1601.17; Wed, 6 Feb 2019 22:46:04 +0000 Received: from CO1NAM05FT038.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e50::203) by BYAPR07CA0046.outlook.office365.com (2603:10b6:a03:60::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1601.17 via Frontend Transport; Wed, 6 Feb 2019 22:46:04 +0000 Authentication-Results: spf=fail (sender IP is 199.233.58.38) smtp.mailfrom=marvell.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=marvell.com; Received-SPF: Fail (protection.outlook.com: domain of marvell.com does not designate 199.233.58.38 as permitted sender) receiver=protection.outlook.com; client-ip=199.233.58.38; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (199.233.58.38) by CO1NAM05FT038.mail.protection.outlook.com (10.152.96.151) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.20.1580.2 via Frontend Transport; Wed, 6 Feb 2019 22:46:04 +0000 Received: from dut1171.mv.qlogic.com (10.112.88.18) by CAEXCH02.caveonetworks.com (10.67.98.110) with Microsoft SMTP Server (TLS) id 14.2.347.0; Wed, 6 Feb 2019 14:43:52 -0800 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id x16MhqYd017095; Wed, 6 Feb 2019 14:43:52 -0800 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id x16MhqwI017094; Wed, 6 Feb 2019 14:43:52 -0800 From: Manish Chopra To: CC: , , Subject: [PATCH net 1/6] qed: Fix EQ full firmware assert. Date: Wed, 6 Feb 2019 14:43:42 -0800 Message-ID: <20190206224347.17054-2-manishc@marvell.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20190206224347.17054-1-manishc@marvell.com> References: <20190206224347.17054-1-manishc@marvell.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131939667643439304; (abac79dc-c90b-41ba-8033-08d666125e47); (abac79dc-c90b-41ba-8033-08d666125e47) X-Forefront-Antispam-Report: CIP:199.233.58.38; IPV:CAL; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(376002)(346002)(136003)(396003)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(498600001)(86362001)(476003)(107886003)(446003)(126002)(336012)(6666004)(97736004)(51416003)(2616005)(50466002)(47776003)(1076003)(4326008)(14444005)(356004)(11346002)(6862004)(76176011)(85426001)(486006)(16586007)(42186006)(54906003)(36906005)(316002)(48376002)(305945005)(26005)(69596002)(53936002)(2351001)(80596001)(8676002)(2906002)(105606002)(68736007)(87636003)(8936002)(36756003)(50226002)(26826003)(106466001)(81156014)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB2909; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; CO1NAM05FT038; 1:wk6yS74bBA1OgRu7nziYf1+Krm7H6CQl/PDh4yRQmvydGVTVn9ZcBkMVLF6FEcoPPTWBUJmGe99RlAQkg7KZQFZMFWxq7VgYHxgJ6xv4veN21GOX7cCD8rvQX67dUtLwQKL471xojmvcYBA8PR8Erw== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bedca930-007c-4fe0-fdc9-08d68c84e016 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(5600110)(711020)(4605077)(2017052603328); SRVR:MWHPR07MB2909; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2909; 3:U8paAtXyAbPkSooz50Lx/fa1Stt01+yIXl/Z3jYl73o1rM6YqsoGg+lTv15I7lXinpunneYvYVN2ACzII3sADZdAUGCXTOyPXXpLat/jymDLko3FbgWq8yYQ6zrfKV2HPJOpZzsp7jmpRSyU5Yq9nbES9QOnlKtSxmGPZuGD936OkBXOko0IOl+K23AqAeV7m4fl3g6Ypp3eoF+bb2saPPVcfNR4Ckl1ecMwS5gdnX1hnAun1wN2jIaItrY4Mg7ruYWJEd8Q37Q2qh3CDitiVADtKR9YaR5JQy+wX5z4kwPHSnlLtScIV6sGfNE5XED8HIJ62l6ydWgOMYSOrC7W8zcuLyFwec/80Opmgjn/kTeICrbKN8ctqKam2lcXcXHP; 25:gFEEqJco3LYgZZuCiRcAudg4dK1anlPg259S7Bk6oeI35CRrYsbyxFmi7JhCRZ+EscRqiYrax1QbDdxlcqMcU7yF+YSDqJgGUF9qfvqflztiYgIHb0E5LHAvOX74fbH72tWsaQ+ESTFgOaznte7P/jFBnMmJhFKIeR/iVlfkfV28g0Uvl3Jma611+tea7BFKDCTOL0zcSDUe/GaKka5NeD6OH+WjLz/OWr0LPd+iG9hfFzUBkolE6LOD3CLOer+RcDFb2FU+Y5u+bkLvZjGBYb+w9T+DRhMJJ/Le2Qqo1aaf3IDHUUPApa/8kGSKstw4I3hNIZ3C/Ivh/UHWEv7pPg== X-MS-TrafficTypeDiagnostic: MWHPR07MB2909: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2909; 31:cIymsGiT3rDusz5MXSiihrb2wQf+SypUHObnuVnoxzgaehn8szyB17UbNbMjPzfraIs3EEtTZ46Zsv+0DPp6C8ntXlIqN9/1mscG+6L4ACmhubqnJSUQCiW2+ZlapJM0yghZHxkW9gyASBKCURxbjPSaidFnhIb6gUhIxhhF68zqrhR7bVtCsJ9Z/tY6oOx/xhTJcY1K3b+kIHzYEoBE6pG7soMWt9E+JolaXdG2ll4=; 4:R5AxH65k0veGzdsAlGfG3gGSV7pjx09oK8FxgMRiCsPezxrEpilWPqneYeyrMt4xusq/iUuAeFPFw/GsqSnANSC7aLqTOP0GUJJ8IzJIRrSffCPW8jIu893vHKVDlFMiVAv/AV+/WG5YJYk3ADjBBSYFccAa1kVqwBmFQOjcDBzeYDEGRWR/3smEUTTSOCQiboGtAO0R/aPK5kzWZpQ5GtDiu7s/BExArdprQ3gM1kLUJV22OYrDSStbD5A1xoN0YsoQYIM9TFrXlze2gaZFslCbns0QMemkopg5OEc3KySGtAYtr7SPG0zwpo40UFcI X-Microsoft-Antispam-PRVS: X-Forefront-PRVS: 0940A19703 X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2909; 23:n5tAep7jKXNWcNhlLeTOEeGYbbJTQ/Ujp8DIinWt3rZwnTD9yNlN0JZJq4/0RAuUI+kPP2hAi2nIPB+9qRr+ZX49ovHEf6pH7fbHlL4pIt22H5VaQTk9b5R9pbVQ7jeGDSNrNZ61piaCE55aAFzg0A4MPGBsb4EQ/5DcUuS+hWQxQADU43Gs+NOcAt/EnL9Gcz9GeRxmISAhndhR3ApsrxEnh7i4gy+zYOPyaUrKsoq66HU7DEnFTzcn89pH1yhi7wlAI08BGMOk0ZwbLqQ0lWUqE79qA22+dZ8KFaW9CCvhP9WFK3z//UFaSHfbkTrmAVOXtxjfIiny0/tVGLD58YsBD2PTyfkGU0TOIe93xQfCvXFPi7AuQA2UQXBL/aQ5eGguU1WOsPur9eWN1kq2nLbQTieEgsfpyIzl+Bwoivdyqcajck8OAH8s+o2/dIYZ2nYrzxRU/ivaCmixdwlcHW5BckVuhqlRtyPWFzAzx5ubA/PtFZsARM6jFhq1NgUrAxdG/x8BZR3ZEclfetJ6PSGdIr7aQ0uw+/4Bx21waqTV3kUJkQFg2ogjzmQ0a1fUd1nSDS8HBT6vT/uP2f4mhJO37sAlOTxYfRQO9hZRBRNXhk21T9KVSNQKjWL76dKrpEh9/I5h8Q53/6dgNFeQOIOMpAhSdMOshosp4E4oMHAv5uqLnFUvdUM1WyTZTD5AD/krAYKggCD3P9wEGz0NCRmMS6MVxFgSfKZ7T7aeYBCkHVFaRMEEVE4MGV/ARAl7pWXnm+n6Zs9LqfF3Vl5Zg4Ah9XCPRc3z+k2r8VaRsSDKe3Os0iFDElDiHwV6pitPx3+JXGugRgjena9nrOIX56etzgPOs2VOCaZoB0tZoTE5pHCSWXbGLtfR9PzVvaAUCzPOB8Uov5wc49BfiI1Rw5CRzq3VsOTUEZxzyanFFx52M8g7JjPVQVnlVn6ZuJ+J//omQqPBe8rU4Fg18A0SpJRV6ofw9OOMH033RhD8WwOx0sBZbKARHhqdSzD2mJm1S1EvUNZgWy/2S13mTHpZEV/3ztq0SYHqz2dVT/cVHvgGXb/ty71bXrITf+Is+KOv3ff2d/VgyoF7yVQSqYYZXt2iiWBB7uKNe1VWszrK2Kfl/dUm8Zc5Lqbw1Q6pPZ6XM/hkXAQdEj9l/glFaI21X57LNl9zbygoB6gu7V0bqfBvdBInJl7M9U+awV1cyiV89QENvFP+oH+KmfanS6IGRGs/inxivN+K5UCV9Cw1qSlwDXWmkAfCle6YPIYz8a2L X-Microsoft-Antispam-Message-Info: SKPufP0jhM+MjwkovoucqXE0lAKy4LUFWqkdKP8LH6rTY2ovQKd90QqrUfEnf8QxazBbLvrYoS2rMbypu650/7oyHGCdJp3WZmLwmWAH4wkxznaKS3pctkG3LUFgnnNuw75zIOXPKK/YKGvmuC0nti+2sRx/vI4rwyKvhImEys+g9xMw3vrGgaELcp8B1JkR1u7zBgEtvKWy7XdRR5rlYTMREgKb8l56mps+uMryjNMiQ9IzFzDOKQeSHmQ9hBCFtOdSWagheO2P+dhbUl2tVvU16vRfwycHh7xVmCA62/iNfEvU9mNJT9fK9StcD925+OdNKzIMbpezRJCoZ/VjsS4giqpvbVj3R1dePGBmviIMLrqzjx9JwGpaO/OGTg2icg6YuPqFnAtjT8Bu+//l7TKS7ibtufgmCZNQIuuYdEg= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB2909; 6:MDKbGYLeYn7Aog3xQh/ULVkEOR8So4y+3yCTw66GcsQSBHihfTn4523iSrYSgvvgTbq9Y61zwtosckeakHxPVDl2pfgcD95Caua/6OFGBvJC29eq6G6bxhtIkK5GRAF4Ml6PBjYYQTEqldhwPDA4m7YGO0Xc9kFjhvTphrpYRbDfChYx0nq91Iy5QyDPB4IfdZPzZmRGl7td+P43ocISlFmy0VYT6arBTTwEfgrDGuENN0j+bbgVZIzN572LM7JswjSvA1hQuBbUjrb6e99nNIFfpN0xGbuA1sSY890sWCX1qK43A09lh52ghDsG9jbaHCQBfPmXRxhu+S9q4Vnnz5M/o8we8bBCdL3A8+sMeJaxH8MGGrmyLUEcF5RKzY8DgQ3RpTkT0JsFBNsHxUQ/9OndPTPRcc/fhnvBEHKKhlqGgJUtuJb/dARhwUo20y/hqWtlOHDch7wseHK4/nMxTw==; 5:nkPq98lZ42t+smfnmxYOALXhwY217YOCTeF++kIKDeEpQotioAQiTXHtX53HamDR6iFDSi+A+qW/9bMzdj2qlP68BWzdoiD6OYUGT5ztLDFQ5PGVhyURLPTDdU+KyzrN/GJzLAScf/t3Th617BYzvYgltOQw1xp3kqCjUq6e0FlizWd/H/qThOy+vPZqSiyiTv0DPPi7o0HmFO+sYlZ1Jg==; 7:FXRWIJt8Vqzr/CBqQI6q7aSiz5zB2pXSmSdJasLESsxL4evnzIheqGA2Ws6v4uA63RDN2rYd9HIltbkHw9PJGZMUmOKmfSEmq4ZdA7SPH6jYdQa406SknFq7V1Gva4JI4fZxtOu/pTawR9qt8/m8+g== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2019 22:46:04.0066 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bedca930-007c-4fe0-fdc9-08d68c84e016 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[199.233.58.38]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB2909 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When slowpath messages are sent with high rate, the resulting events can lead to a FW assert in case they are not handled fast enough (Event Queue Full assert). Attempt to send queued slowpath messages only after the newly evacuated entries in the EQ ring are indicated to FW. Signed-off-by: Manish Chopra Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_sp.h | 1 + drivers/net/ethernet/qlogic/qed/qed_spq.c | 15 +++++++-------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_sp.h b/drivers/net/ethernet/qlogic/qed/qed_sp.h index 4179c90..96ab77a 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_sp.h +++ b/drivers/net/ethernet/qlogic/qed/qed_sp.h @@ -382,6 +382,7 @@ int qed_spq_completion(struct qed_hwfn *p_hwfn, * @param p_hwfn */ void qed_consq_free(struct qed_hwfn *p_hwfn); +int qed_spq_pend_post(struct qed_hwfn *p_hwfn); /** * @file diff --git a/drivers/net/ethernet/qlogic/qed/qed_spq.c b/drivers/net/ethernet/qlogic/qed/qed_spq.c index eb88bbc..ba64ff9 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_spq.c +++ b/drivers/net/ethernet/qlogic/qed/qed_spq.c @@ -397,6 +397,11 @@ int qed_eq_completion(struct qed_hwfn *p_hwfn, void *cookie) qed_eq_prod_update(p_hwfn, qed_chain_get_prod_idx(p_chain)); + /* Attempt to post pending requests */ + spin_lock_bh(&p_hwfn->p_spq->lock); + rc = qed_spq_pend_post(p_hwfn); + spin_unlock_bh(&p_hwfn->p_spq->lock); + return rc; } @@ -767,7 +772,7 @@ static int qed_spq_post_list(struct qed_hwfn *p_hwfn, return 0; } -static int qed_spq_pend_post(struct qed_hwfn *p_hwfn) +int qed_spq_pend_post(struct qed_hwfn *p_hwfn) { struct qed_spq *p_spq = p_hwfn->p_spq; struct qed_spq_entry *p_ent = NULL; @@ -905,7 +910,6 @@ int qed_spq_completion(struct qed_hwfn *p_hwfn, struct qed_spq_entry *p_ent = NULL; struct qed_spq_entry *tmp; struct qed_spq_entry *found = NULL; - int rc; if (!p_hwfn) return -EINVAL; @@ -963,12 +967,7 @@ int qed_spq_completion(struct qed_hwfn *p_hwfn, */ qed_spq_return_entry(p_hwfn, found); - /* Attempt to post pending requests */ - spin_lock_bh(&p_spq->lock); - rc = qed_spq_pend_post(p_hwfn); - spin_unlock_bh(&p_spq->lock); - - return rc; + return 0; } int qed_consq_alloc(struct qed_hwfn *p_hwfn)