| Message ID | 20190204144442.5704-1-jakub.kicinski@netronome.com |
|---|---|
| State | Superseded |
| Delegated to: | David Ahern |
| Headers | show |
| Series | [iproute2-next,v2] devlink: report cell size | expand |
Mon, Feb 04, 2019 at 03:44:42PM CET, jakub.kicinski@netronome.com wrote: >Print the value of DEVLINK_ATTR_SB_POOL_CELL_SIZE, if reported. > >Example: >pci/0000:82:00.0: > sb 1 pool 0 type egress size 40945664 thtype static cell_size 2048 > sb 2 pool 0 type egress size 258867200 thtype static cell_size 10240 >... > >v2: - fix spelling. > >Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> >Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com> >--- > devlink/devlink.c | 3 +++ > man/man8/devlink-sb.8 | 10 ++++++++++ > 2 files changed, 13 insertions(+) > >diff --git a/devlink/devlink.c b/devlink/devlink.c >index fc4b18d1b613..40f6105af109 100644 >--- a/devlink/devlink.c >+++ b/devlink/devlink.c >@@ -2891,6 +2891,9 @@ static void pr_out_sb_pool(struct dl *dl, struct nlattr **tb) > mnl_attr_get_u32(tb[DEVLINK_ATTR_SB_POOL_SIZE])); > pr_out_str(dl, "thtype", > threshold_type_name(mnl_attr_get_u8(tb[DEVLINK_ATTR_SB_POOL_THRESHOLD_TYPE]))); >+ if (tb[DEVLINK_ATTR_SB_POOL_CELL_SIZE]) >+ pr_out_uint(dl, "cell_size", >+ mnl_attr_get_u32(tb[DEVLINK_ATTR_SB_POOL_CELL_SIZE])); > pr_out_handle_end(dl); > } > >diff --git a/man/man8/devlink-sb.8 b/man/man8/devlink-sb.8 >index 1882833a3fa7..0deacd9ccd23 100644 >--- a/man/man8/devlink-sb.8 >+++ b/man/man8/devlink-sb.8 >@@ -128,6 +128,16 @@ Behaviour of this argument it the same for every command. > - specifies the devlink device to show pools. > If this argument is omitted all pools of all devices are listed. > >+Display available pools listing their >+.B type, size, thtype >+and >+.B cell_size. cell_size >+is the allocation granularity of memory within the shared buffer. Drivers Double space. Other than this nit, looks fine to me. >+may round up, round down or reject >+.B size >+passed to the set command if it is not multiple of >+.B cell_size. >+ > .SS devlink sb pool set - set attributes of pool > > .PP >-- >2.19.2 >
diff --git a/devlink/devlink.c b/devlink/devlink.c index fc4b18d1b613..40f6105af109 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -2891,6 +2891,9 @@ static void pr_out_sb_pool(struct dl *dl, struct nlattr **tb) mnl_attr_get_u32(tb[DEVLINK_ATTR_SB_POOL_SIZE])); pr_out_str(dl, "thtype", threshold_type_name(mnl_attr_get_u8(tb[DEVLINK_ATTR_SB_POOL_THRESHOLD_TYPE]))); + if (tb[DEVLINK_ATTR_SB_POOL_CELL_SIZE]) + pr_out_uint(dl, "cell_size", + mnl_attr_get_u32(tb[DEVLINK_ATTR_SB_POOL_CELL_SIZE])); pr_out_handle_end(dl); } diff --git a/man/man8/devlink-sb.8 b/man/man8/devlink-sb.8 index 1882833a3fa7..0deacd9ccd23 100644 --- a/man/man8/devlink-sb.8 +++ b/man/man8/devlink-sb.8 @@ -128,6 +128,16 @@ Behaviour of this argument it the same for every command. - specifies the devlink device to show pools. If this argument is omitted all pools of all devices are listed. +Display available pools listing their +.B type, size, thtype +and +.B cell_size. cell_size +is the allocation granularity of memory within the shared buffer. Drivers +may round up, round down or reject +.B size +passed to the set command if it is not multiple of +.B cell_size. + .SS devlink sb pool set - set attributes of pool .PP