| Message ID | 20190124180724.20910-1-malat@debian.org |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | [1/2] Bluetooth: Annotate implicit fall through in l2cap_config_rsp | expand |
Hi Mathieu, > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > This commit removes the following warning: > > net/bluetooth/l2cap_core.c:4223:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > Signed-off-by: Mathieu Malaterre <malat@debian.org> > --- > net/bluetooth/l2cap_core.c | 1 + > 1 file changed, 1 insertion(+) the patches don’t apply cleanly against bluetooth-next tree. Please fix it up and resend. Regards Marcel
On Fri, Jan 25, 2019 at 8:56 AM Marcel Holtmann <marcel@holtmann.org> wrote: > > Hi Mathieu, > > > There is a plan to build the kernel with -Wimplicit-fallthrough and > > this place in the code produced a warning (W=1). > > > > This commit removes the following warning: > > > > net/bluetooth/l2cap_core.c:4223:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > > > > Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > Signed-off-by: Mathieu Malaterre <malat@debian.org> > > --- > > net/bluetooth/l2cap_core.c | 1 + > > 1 file changed, 1 insertion(+) > > the patches don’t apply cleanly against bluetooth-next tree. Please fix it up and resend. Never mind, both warnings are already fixed by: 6317950c1b9c Bluetooth: Mark expected switch fall-throughs Sorry for the noise > Regards > > Marcel >
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 2a7fb517d460..a5b76e24940a 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -4244,6 +4244,7 @@ static inline int l2cap_config_rsp(struct l2cap_conn *conn, goto done; break; } + /* fall through */ default: l2cap_chan_set_err(chan, ECONNRESET);
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warning (W=1). This commit removes the following warning: net/bluetooth/l2cap_core.c:4223:6: warning: this statement may fall through [-Wimplicit-fallthrough=] Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk> Signed-off-by: Mathieu Malaterre <malat@debian.org> --- net/bluetooth/l2cap_core.c | 1 + 1 file changed, 1 insertion(+)