diff mbox series

[v2] net: dpaa2: improve PTP Kconfig option

Message ID 20190121062637.48449-1-yangbo.lu@nxp.com
State Accepted
Delegated to: David Miller
Headers show
Series [v2] net: dpaa2: improve PTP Kconfig option | expand

Commit Message

Yangbo Lu Jan. 21, 2019, 6:26 a.m. UTC
Converted to use "imply" instead of "select" for PTP_1588_CLOCK
driver selecting. This could break the hard dependency between
the PTP clock subsystem and ethernet drivers.
This patch also set "default y" for dpaa2 ptp driver building to
provide user an available ptp clock in default.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
Changes for v2:
	- Converted to use imply for PTP_1588_CLOCK.
	- Modified commit message.
---
 drivers/net/ethernet/freescale/dpaa2/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Comments

Richard Cochran Jan. 21, 2019, 6:25 p.m. UTC | #1
On Mon, Jan 21, 2019 at 02:26:37PM +0800, Yangbo Lu wrote:
> Converted to use "imply" instead of "select" for PTP_1588_CLOCK
> driver selecting. This could break the hard dependency between
> the PTP clock subsystem and ethernet drivers.
> This patch also set "default y" for dpaa2 ptp driver building to
> provide user an available ptp clock in default.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>

Acked-by: Richard Cochran <richardcochran@gmail.com>
David Miller Jan. 23, 2019, 1:38 a.m. UTC | #2
From: Yangbo Lu <yangbo.lu@nxp.com>
Date: Mon, 21 Jan 2019 14:26:37 +0800

> Converted to use "imply" instead of "select" for PTP_1588_CLOCK
> driver selecting. This could break the hard dependency between
> the PTP clock subsystem and ethernet drivers.
> This patch also set "default y" for dpaa2 ptp driver building to
> provide user an available ptp clock in default.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
> Changes for v2:
> 	- Converted to use imply for PTP_1588_CLOCK.
> 	- Modified commit message.

Applied.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig
index 809a155..f6d244c 100644
--- a/drivers/net/ethernet/freescale/dpaa2/Kconfig
+++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
@@ -9,8 +9,9 @@  config FSL_DPAA2_ETH
 
 config FSL_DPAA2_PTP_CLOCK
 	tristate "Freescale DPAA2 PTP Clock"
-	depends on FSL_DPAA2_ETH && POSIX_TIMERS
-	select PTP_1588_CLOCK
+	depends on FSL_DPAA2_ETH
+	imply PTP_1588_CLOCK
+	default y
 	help
 	  This driver adds support for using the DPAA2 1588 timer module
 	  as a PTP clock.