From patchwork Wed Jan 2 20:42:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mauricio Faria de Oliveira X-Patchwork-Id: 1020067 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43VNKZ2kmVz9s4s for ; Thu, 3 Jan 2019 07:42:58 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727598AbfABUm5 (ORCPT ); Wed, 2 Jan 2019 15:42:57 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:43799 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727193AbfABUm4 (ORCPT ); Wed, 2 Jan 2019 15:42:56 -0500 Received: from mail-qt1-f198.google.com ([209.85.160.198]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1genLq-0002bA-Hz for netdev@vger.kernel.org; Wed, 02 Jan 2019 20:42:54 +0000 Received: by mail-qt1-f198.google.com with SMTP id q3so40301457qtq.15 for ; Wed, 02 Jan 2019 12:42:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7hsB4K/KXe1k3QlsGyVqMxbvu2djv1itGQLn7RbJ1+Q=; b=DyVYPBGyimFGPOwk7mf57jVSoRRwArE1O43dfQRl+t4ex3yYOibZAXRQFZgnmJtoOl 8E6jnUGBgiz28Qumm+XkTZ+q1xN76JiflzqhhicQ+92ZJMsGKITsz8jX00yOtR25Wre7 juq8j1hlREHXxKhcOVZf1xsAr+9Lp9Bs6QG0ZD4lKkOgi/S9VjzE6oz6V5jGWtitBNJh i+JQegr82GG4Ay3eixGHTTOgE7kGn01S6R+LyuQrRroRbi8Ft4n5J4N/PhsdYPYYqPGf 6AAj314thjN8eJhqpVBe9O99RRIWYSqAqdl2iXuhMMcDXtnShAX5qJI6uZR5rYSsjJHk aVpg== X-Gm-Message-State: AJcUukePPM09Rvkt7eb7//h7976ogkyP73Rko0lzO93m8mC1osPiMbqq hQiNOme4XhscdZqlTKAqrLxqdGMxu2RwjSgO+lbx3kC6ML4/qZX3iR80kqGlIjwnMIUgx577tDh xqbnLanXUJRSxw5m2N0SeanxsuVFxn6aFWQ== X-Received: by 2002:a0c:aee1:: with SMTP id n33mr43836990qvd.169.1546461773611; Wed, 02 Jan 2019 12:42:53 -0800 (PST) X-Google-Smtp-Source: ALg8bN6wVP7agKnkx64dMcH7Onb0oAAlZWLmm0AML+djlkN1rzPk0QITqgyVxutpKdVMvcclEZFRIw== X-Received: by 2002:a0c:aee1:: with SMTP id n33mr43836985qvd.169.1546461773461; Wed, 02 Jan 2019 12:42:53 -0800 (PST) Received: from localhost.localdomain ([179.159.56.118]) by smtp.gmail.com with ESMTPSA id e17sm26679381qte.12.2019.01.02.12.42.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Jan 2019 12:42:53 -0800 (PST) From: Mauricio Faria de Oliveira To: stable@vger.kernel.org, netdev@vger.kernel.org, Florian Westphal Cc: Alakesh Haloi , nivedita.singhvi@canonical.com, Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Yi-Hung Wei Subject: [PATCH v2 4.14 1/5] netfilter: xt_connlimit: don't store address in the conn nodes Date: Wed, 2 Jan 2019 18:42:00 -0200 Message-Id: <20190102204204.12389-2-mfo@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190102204204.12389-1-mfo@canonical.com> References: <20190102204204.12389-1-mfo@canonical.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Florian Westphal commit ce49480dba8666cba0106e8e31a942c9ce4c438a upstream. Only stored, never read. This is a leftover from commit 7d08487777c8 ("netfilter: connlimit: use rbtree for per-host conntrack obj storage"), which added the rbtree node struct that stores the address instead. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso [mfo: backport: refresh context lines and use older symbol/file names: - nf_conncount.c -> xt_connlimit.c. - nf_conncount_rb -> xt_connlimit_rb - nf_conncount_tuple -> xt_connlimit_conn - additionally, remove the add_hlist() 'addr' parameter that isn't used and removed later upstream with commit 625c556118f3 ("netfilter: connlimit: split xt_connlimit into front and backend") in the rename from 'xt_connlimit.c' to 'nf_conncount.c', a big refactor, so do it here, while still here in this related patch.] Signed-off-by: Mauricio Faria de Oliveira --- net/netfilter/xt_connlimit.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/netfilter/xt_connlimit.c b/net/netfilter/xt_connlimit.c index ffa8eec..79d4151 100644 --- a/net/netfilter/xt_connlimit.c +++ b/net/netfilter/xt_connlimit.c @@ -46,7 +46,6 @@ struct xt_connlimit_conn { struct hlist_node node; struct nf_conntrack_tuple tuple; - union nf_inet_addr addr; }; struct xt_connlimit_rb { @@ -116,8 +115,7 @@ same_source_net(const union nf_inet_addr *addr, } static bool add_hlist(struct hlist_head *head, - const struct nf_conntrack_tuple *tuple, - const union nf_inet_addr *addr) + const struct nf_conntrack_tuple *tuple) { struct xt_connlimit_conn *conn; @@ -125,7 +123,6 @@ static bool add_hlist(struct hlist_head *head, if (conn == NULL) return false; conn->tuple = *tuple; - conn->addr = *addr; hlist_add_head(&conn->node, head); return true; } @@ -231,7 +228,7 @@ count_tree(struct net *net, struct rb_root *root, if (!addit) return count; - if (!add_hlist(&rbconn->hhead, tuple, addr)) + if (!add_hlist(&rbconn->hhead, tuple)) return 0; /* hotdrop */ return count + 1; @@ -270,7 +267,6 @@ count_tree(struct net *net, struct rb_root *root, } conn->tuple = *tuple; - conn->addr = *addr; rbconn->addr = *addr; INIT_HLIST_HEAD(&rbconn->hhead);