From patchwork Wed Dec 26 02:55:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 1018522 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="pF3+Uk/M"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43Pczy3gsdz9sCQ for ; Wed, 26 Dec 2018 13:56:14 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726982AbeLZC4J (ORCPT ); Tue, 25 Dec 2018 21:56:09 -0500 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:48522 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbeLZC4I (ORCPT ); Tue, 25 Dec 2018 21:56:08 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 39913B11 for ; Wed, 26 Dec 2018 02:56:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WpElgPcEXPBT for ; Tue, 25 Dec 2018 20:56:07 -0600 (CST) Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 0C2FDA0B for ; Tue, 25 Dec 2018 20:56:07 -0600 (CST) Received: by mail-io1-f70.google.com with SMTP id x2so17826443ioa.23 for ; Tue, 25 Dec 2018 18:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=IpHCPony0Yw91k/Xth9ZNoao1j2soIv/Kezjj2ATXyQ=; b=pF3+Uk/M71PHl2gDU3siqxEdeHXX+0D9yne5Z9UH6+Nmt+0JrDQ6lTITqKKevS4ivN 2HP+0siRbmJP6Tl6PiGcMpVr63mHIGvxeR6pN/uRGrfNuHLREgWMyjy1cwwwW4s5UTyX NNn6JmTZk+AXQT88J01WobBGgH2gz7KVdXfDn4IEyK3nux521vskcRoGYh53GKZ4WqFW wl4MvH679wIR6fsVHjEyCB1YRz0BjwF0l6vWPihxrCcUDWf9oj9a/4JpchpXN0FY3A2d 1Cy4aViE6vvwE4rdZcRI+O0ZvfFmI411pkuFMDtA7VmnCEFQEsPjmoTTwfg1oXndBNtB cB5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IpHCPony0Yw91k/Xth9ZNoao1j2soIv/Kezjj2ATXyQ=; b=ErdQcBJpjAxvdrIfOAXnmg/QDUdHXVPa9Bj6dfc7XobT5cIEmMxYReHOsU0cLQ0eyn x2wPZCaDzDlzB8HXi7zw1JYUitmAUoeemosFHl7rJfqSskzLb+fN9vU7xxBpEcPD4YiB 8VArbtU4m10qIqOl2wNtDjcQGKp0VRQ3ReADDrBqeFJz+8blVcSltKzThKhzsaV2ydyI Z/wcZQBiRf82JjXiIS8DNYnkb4A818AQzNeyKpQTFrcwPll0tOBc5Ru42BhllEE+lKop O/L2fYRvdWD1HEZItSodBhHHZPUnnKg8ukDvOejDbEdMzC8nvkNuilVvmGjLlebB3A73 0l/A== X-Gm-Message-State: AJcUukfR5qGYaIQEsfan4oKo7qd/7Cqkvx/VK1Bri7juF8zDvVUrp0g/ iV+26OlzPtn+4adOYjedpzs+0JjoxXRms2QZjNuFNeogYz9UCjl/m8Ij0SRTCgeug7gJ5heQQ0k lix5TEhHrqj1/zQRaVLaR X-Received: by 2002:a6b:7602:: with SMTP id g2mr11703706iom.135.1545792966683; Tue, 25 Dec 2018 18:56:06 -0800 (PST) X-Google-Smtp-Source: ALg8bN6UJP1xtIqVNabcTTcF4DvsB6ls+x/X5R6I9B1qxZu+OakChf7NUCPq6cPYuxkAs8/FKY4b9A== X-Received: by 2002:a6b:7602:: with SMTP id g2mr11703695iom.135.1545792966465; Tue, 25 Dec 2018 18:56:06 -0800 (PST) Received: from localhost.localdomain (host-173-230-104-22.mnmigsc.mn.minneapolis.us.clients.pavlovmedia.net. [173.230.104.22]) by smtp.gmail.com with ESMTPSA id x79sm11504816ita.34.2018.12.25.18.56.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 25 Dec 2018 18:56:05 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, "David S. Miller" , "Gustavo A. R. Silva" , Florian Fainelli , =?utf-8?q?Hern=C3=A1n_Gonzal?= =?utf-8?q?ez?= , Ivan Khoronzhuk , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: (cpts) fix a missing check of clk_prepare Date: Tue, 25 Dec 2018 20:55:37 -0600 Message-Id: <20181226025539.72561-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.2 (Apple Git-113) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org clk_prepare() could fail, so let's check its status, and if it fails, return its error code upstream. Signed-off-by: Kangjie Lu --- drivers/net/ethernet/ti/cpts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c index b96b93c686bf..4f644ac314fe 100644 --- a/drivers/net/ethernet/ti/cpts.c +++ b/drivers/net/ethernet/ti/cpts.c @@ -572,7 +572,9 @@ struct cpts *cpts_create(struct device *dev, void __iomem *regs, return ERR_CAST(cpts->refclk); } - clk_prepare(cpts->refclk); + ret = clk_prepare(cpts->refclk); + if (ret) + return ERR_PTR(ret); cpts->cc.read = cpts_systim_read; cpts->cc.mask = CLOCKSOURCE_MASK(32);