From patchwork Mon Dec 24 21:21:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 1018305 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="Kp+VCFKt"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43Nscb3JgDz9sCr for ; Tue, 25 Dec 2018 08:21:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725819AbeLXVVc (ORCPT ); Mon, 24 Dec 2018 16:21:32 -0500 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:57786 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbeLXVVc (ORCPT ); Mon, 24 Dec 2018 16:21:32 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 669FAB89 for ; Mon, 24 Dec 2018 21:21:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BUmnaUaA1O2p for ; Mon, 24 Dec 2018 15:21:30 -0600 (CST) Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 43035B67 for ; Mon, 24 Dec 2018 15:21:30 -0600 (CST) Received: by mail-io1-f72.google.com with SMTP id f7so1074161ioo.8 for ; Mon, 24 Dec 2018 13:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=43gchWhnjuYleacimEGTo0K+ifmfHPKPUbsTzY3Migc=; b=Kp+VCFKtAAXat8EfZJ+egoNYEX0Iuo1Bx4EBj0iZJ9DH2h7o1CkSC9UF4QYGvdQ7aJ z5h3baUFHD90gJRSixMmsnNZgQ9EjtbpxWA6ZgV7My5GphHDONqKnaio7zSDKdNGS58+ emHHMoimeNMVKamllEjinpBvh2HGgl3mgkrOrsfD6BAQVWzhyLXmOgdNOQmwUNioOJIB lOBghsVc/tksHVI3oJ1WML1J2+usX9r/wKnK5gByKYHVeGigHQo0M/rJ9YZwL/SwPtpa hGnTVTuHHBrScmQabIq4rb5Y9TJCA5yIknr8AU5yLstFckamzTUAVUjjWpNuxeCdcGPc pc2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=43gchWhnjuYleacimEGTo0K+ifmfHPKPUbsTzY3Migc=; b=tib+mMY26wOsUjdpBPeQjEeELgT2yTkLyUROeNupbrKYarRdGBFobXyfe0iHqpajdF 5K46Wn+ZponwwkRtvRjBJKe5O1pHjFguuOF8ZpTXNktVcPu96D4N+Zr5c8SnjNdgXuDz 3KraxV6PdnVJeZh4I6CduX96+BTZfKl2D3CsKv7xAIdLmOMAw+GItTejHzxOPZ5Yf26V SOi2TcDO0VbPOh9oF710FwSgAvpihlhD/1nVcSggcK4srSVrojzuSlBUKDozRTpQa69O rcMh0NWiLhR9BPyrZnz3tUbU7akIIA6YcjEjvcXe2GYYTF1xTuOb4PcTNOJYX5HS5Mnh UtUw== X-Gm-Message-State: AA+aEWbcdngjQqfpstX3o0lKJSrQV+J4xkoav6dI4wxWN/q5KTscgZ3Y A6FiPH6uneQbtDOkCDZZHqk5sak5dQINEwYpWTvsTsUY7G+CpWY7HVzqXTm1Rv9Tn+qILlzqA+K IP3UDXrY5Mmw9olfAzkVl X-Received: by 2002:a02:9d4b:: with SMTP id m11mr9645096jal.121.1545686489841; Mon, 24 Dec 2018 13:21:29 -0800 (PST) X-Google-Smtp-Source: AFSGD/V/JJk7MbNrGNVT1fPMQZjDNyT5BoqOOfGblM/MUd5wjcm3ZViiJFSxFUxtrkLoN/GVogiAFw== X-Received: by 2002:a02:9d4b:: with SMTP id m11mr9645085jal.121.1545686489600; Mon, 24 Dec 2018 13:21:29 -0800 (PST) Received: from cs-u-syssec1.cs.umn.edu (cs-u-syssec1.cs.umn.edu. [134.84.121.78]) by smtp.gmail.com with ESMTPSA id p132sm8878267itb.35.2018.12.24.13.21.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Dec 2018 13:21:28 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Arjun Vynipadath , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: chelsio: Add a missing check on cudg_get_buffer Date: Mon, 24 Dec 2018 15:21:21 -0600 Message-Id: <20181224212121.25596-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org cudbg_collect_hw_sched() could fail when the function cudg_get_buffer() returns an error. The fix adds a check to the latter function returning error on failure Signed-off-by: Aditya Pakki --- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c index 7c49681407ad..127b1f624413 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c @@ -1229,6 +1229,10 @@ int cudbg_collect_hw_sched(struct cudbg_init *pdbg_init, rc = cudbg_get_buff(pdbg_init, dbg_buff, sizeof(struct cudbg_hw_sched), &temp_buff); + + if (rc) + return rc; + hw_sched_buff = (struct cudbg_hw_sched *)temp_buff.data; hw_sched_buff->map = t4_read_reg(padap, TP_TX_MOD_QUEUE_REQ_MAP_A); hw_sched_buff->mode = TIMERMODE_G(t4_read_reg(padap, TP_MOD_CONFIG_A));