| Message ID | 20181224212121.25596-1-pakki001@umn.edu |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: chelsio: Add a missing check on cudg_get_buffer | expand |
From: Aditya Pakki <pakki001@umn.edu> Date: Mon, 24 Dec 2018 15:21:21 -0600 > cudbg_collect_hw_sched() could fail when the function cudg_get_buffer() > returns an error. The fix adds a check to the latter function returning > error on failure > > Signed-off-by: Aditya Pakki <pakki001@umn.edu> Applied.
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c index 7c49681407ad..127b1f624413 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c @@ -1229,6 +1229,10 @@ int cudbg_collect_hw_sched(struct cudbg_init *pdbg_init, rc = cudbg_get_buff(pdbg_init, dbg_buff, sizeof(struct cudbg_hw_sched), &temp_buff); + + if (rc) + return rc; + hw_sched_buff = (struct cudbg_hw_sched *)temp_buff.data; hw_sched_buff->map = t4_read_reg(padap, TP_TX_MOD_QUEUE_REQ_MAP_A); hw_sched_buff->mode = TIMERMODE_G(t4_read_reg(padap, TP_MOD_CONFIG_A));
cudbg_collect_hw_sched() could fail when the function cudg_get_buffer() returns an error. The fix adds a check to the latter function returning error on failure Signed-off-by: Aditya Pakki <pakki001@umn.edu> --- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 4 ++++ 1 file changed, 4 insertions(+)