From patchwork Mon Dec 24 17:49:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 1018286 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=umn.edu Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=umn.edu header.i=@umn.edu header.b="cMfu2SGG"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43Nmvs4gB4z9s8J for ; Tue, 25 Dec 2018 04:49:45 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725819AbeLXRtj (ORCPT ); Mon, 24 Dec 2018 12:49:39 -0500 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:43148 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbeLXRtj (ORCPT ); Mon, 24 Dec 2018 12:49:39 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id D224A9BB for ; Mon, 24 Dec 2018 17:49:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Uo4rjAaAOB25 for ; Mon, 24 Dec 2018 11:49:37 -0600 (CST) Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id A595B1C6 for ; Mon, 24 Dec 2018 11:49:37 -0600 (CST) Received: by mail-io1-f71.google.com with SMTP id r7so1051887iom.22 for ; Mon, 24 Dec 2018 09:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=2Ao+gJbWRf5uI9O3Ydh6HJbnkX7WsBud85/G+qeySFc=; b=cMfu2SGG1FjYVLehH/K6zaPyFaSLQG+GueW22MwaNqcUyhONdRMdiE6tH+RRx1r7Mp p2QvxWwZuGcI/a9NnJdB1aMC2C4V+swE7AIwXFOEjQLd2KCqGFKpx28BLq2VO7t8UmE1 huZOmutrFwgcd5NCgBkEmTkI02bfMZ27MXMZrbtZnVYs1CGHWuzL4Er6xhfxGgmfFQNg Oahsf5UigCkTN3MDn0X6xb4lKXbrBoIKX2ld/fwHJZQsNOjUWZnkaPHmHYojg+qd4BxO 3JmZqEvw6t+UAblku/LKaur9lP+J1te3vuqbx1in80ZfDqz+/sxro8BQGeKElGuSwNEe Twug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2Ao+gJbWRf5uI9O3Ydh6HJbnkX7WsBud85/G+qeySFc=; b=qq+Hv1bEAf7BTwQqqrnMJmOqfm9GcLdeR3DUWG9XMiPkIcTEgb1P736dix5MdtSNXL Ny/+i/fpgapr/VTnXeYpUl6OzXjf33tTtIfF+nQKB+MtkEmwOko/uXxnxABrqr64lUP6 jiv6i/FvokVkWVxUrNtfbSxggJ8H11r/7mDEOc1VptMg+B588uzkBwtk2QBOopXu1p+S CbQCMilj6dxqPROCNY3qlLCO2k1dWFfeUv9+/6ULBAb/IHzOTA1YMgb/PYOv/6Cqp+CF 3E4PbAA8Iigdmy2PMyGXRmzYp9qNf37kp79xa6l/3lP0gS94Kp5NaOx4T7YU/Fp/5OAC jQjA== X-Gm-Message-State: AJcUukfAxXOZw6vNFu7ehqMtYUly5IrjNmTmuxpOz1vVc/r9u+R8ZPGZ P3UH6EZExlcWhZyCOUu1YlyoyLOuAQVDwrEkpOGdsrAkLLk544yHlKtCTAjMIC2AIgUpgjm/oKj igf77OzxHZMEF7XfNrWtb X-Received: by 2002:a24:bd0e:: with SMTP id x14mr8781548ite.123.1545673777297; Mon, 24 Dec 2018 09:49:37 -0800 (PST) X-Google-Smtp-Source: AFSGD/WQ1NalqcExE04UEJQucz4zQ7nbL2L6/4EOVdP/yEAyxBM4vrGcNqDC6FCXa/0nGbvbM9iYYg== X-Received: by 2002:a24:bd0e:: with SMTP id x14mr8781531ite.123.1545673777055; Mon, 24 Dec 2018 09:49:37 -0800 (PST) Received: from cs-u-syssec1.cs.umn.edu (cs-u-syssec1.cs.umn.edu. [134.84.121.78]) by smtp.gmail.com with ESMTPSA id h16sm11440229ith.25.2018.12.24.09.49.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Dec 2018 09:49:36 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Marek Lindner , Simon Wunderlich , Antonio Quartulli , "David S. Miller" , b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register Date: Mon, 24 Dec 2018 11:49:26 -0600 Message-Id: <20181224174926.20321-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org rtnl_link_register() may fail and can impact registering the device. The fix checks the return value and pushes the error upstream. Signed-off-by: Aditya Pakki --- net/batman-adv/main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c index 69c0d85bceb3..e0007f242823 100644 --- a/net/batman-adv/main.c +++ b/net/batman-adv/main.c @@ -109,7 +109,10 @@ static int __init batadv_init(void) batadv_debugfs_init(); register_netdevice_notifier(&batadv_hard_if_notifier); - rtnl_link_register(&batadv_link_ops); + ret = rtnl_link_register(&batadv_link_ops); + if (ret < 0) + return ret; + batadv_netlink_register(); pr_info("B.A.T.M.A.N. advanced %s (compatibility version %i) loaded\n",