| Message ID | 20181224163017.17362-1-pakki001@umn.edu |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | ipv6/route: Add a missing check on proc_dointvec | expand |
From: Aditya Pakki <pakki001@umn.edu> Date: Mon, 24 Dec 2018 10:30:17 -0600 > While flushing the cache via ipv6_sysctl_rtcache_flush(), the call > to proc_dointvec() may fail. The fix adds a check that returns the > error, on failure. > > Signed-off-by: Aditya Pakki <pakki001@umn.edu> Applied, but honestly running garbage collection even if the value isn't change is completely harmless.
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 059f0531f7c1..5ccdaa27ec53 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -5053,12 +5053,16 @@ int ipv6_sysctl_rtcache_flush(struct ctl_table *ctl, int write, { struct net *net; int delay; + int ret; if (!write) return -EINVAL; net = (struct net *)ctl->extra1; delay = net->ipv6.sysctl.flush_delay; - proc_dointvec(ctl, write, buffer, lenp, ppos); + ret = proc_dointvec(ctl, write, buffer, lenp, ppos); + if (ret) + return ret; + fib6_run_gc(delay <= 0 ? 0 : (unsigned long)delay, net, delay > 0); return 0; }
While flushing the cache via ipv6_sysctl_rtcache_flush(), the call to proc_dointvec() may fail. The fix adds a check that returns the error, on failure. Signed-off-by: Aditya Pakki <pakki001@umn.edu> --- net/ipv6/route.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)