diff mbox series

net: dsa: mv88e6xxx: set ethtool regs version

Message ID 20181217210521.4462-1-vivien.didelot@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series net: dsa: mv88e6xxx: set ethtool regs version | expand

Commit Message

Vivien Didelot Dec. 17, 2018, 9:05 p.m. UTC 
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Currently the ethtool_regs version is set to 0 for all DSA drivers.

Use this field to store the chip ID to simplify the pretty dump of
any interfaces registered by the "dsa" driver.

Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
---
 drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn Dec. 17, 2018, 9:28 p.m. UTC | #1 
On Mon, Dec 17, 2018 at 04:05:21PM -0500, Vivien Didelot wrote:
> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> 
> Currently the ethtool_regs version is set to 0 for all DSA drivers.
> 
> Use this field to store the chip ID to simplify the pretty dump of
> any interfaces registered by the "dsa" driver.

Hi Vivien.

I like this, but it is still not guaranteed to be unique between DSA
drivers.

I suppose once we do get a clash, we can add some extra heuristics.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Florian Fainelli Dec. 17, 2018, 10:12 p.m. UTC | #2 
On December 17, 2018 1:05:21 PM PST, Vivien Didelot <vivien.didelot@gmail.com> wrote:
>From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>
>Currently the ethtool_regs version is set to 0 for all DSA drivers.
>
>Use this field to store the chip ID to simplify the pretty dump of
>any interfaces registered by the "dsa" driver.
>
>Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
David Miller Dec. 18, 2018, 7:29 a.m. UTC | #3 
From: Vivien Didelot <vivien.didelot@gmail.com>
Date: Mon, 17 Dec 2018 16:05:21 -0500

> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> 
> Currently the ethtool_regs version is set to 0 for all DSA drivers.
> 
> Use this field to store the chip ID to simplify the pretty dump of
> any interfaces registered by the "dsa" driver.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index b39e29feefa1..26fb14a7117d 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -1125,7 +1125,7 @@  static void mv88e6xxx_get_regs(struct dsa_switch *ds, int port,
 	u16 *p = _p;
 	int i;
 
-	regs->version = 0;
+	regs->version = chip->info->prod_num;
 
 	memset(p, 0xff, 32 * sizeof(u16));