| Message ID | 20181215153051.13166-3-bluca@debian.org |
|---|---|
| State | Superseded, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
| Series | [iproute2,1/4] Makefile: have check target depend on all | expand |
Hi Luca, > Signed-off-by: Luca Boccassi <bluca@debian.org> Reviewed-by: Petr Vorel <pvorel@suse.cz> > --- > testsuite/tests/ip/route/add_default_route.t | 2 ++ > 1 file changed, 2 insertions(+) > diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/route/add_default_route.t > index 569ba1f8..c536e35f 100755 > --- a/testsuite/tests/ip/route/add_default_route.t > +++ b/testsuite/tests/ip/route/add_default_route.t > @@ -31,3 +31,5 @@ ts_ip "$0" "Add another IPv6 route dst cafe:babe::/64" -6 route add cafe:babe::/ > ts_ip "$0" "Show IPv6 default route" -6 route show default > test_on "default via dead:beef::2 dev $DEV" > test_lines_count 1 > + > +ts_ip "$0" "Del $NEW_DEV dummy interface" link del dev $DEV Shouldn't this be using $DEV instead of $NEW_DEV? ts_ip "$0" "Delete $DEV interface" link del dev $DEV Copy paste from new_link.t? Kind regards, Petr
On Sat, 2018-12-15 at 17:32 +0100, Petr Vorel wrote: > Hi Luca, > > > Signed-off-by: Luca Boccassi <bluca@debian.org> > > Reviewed-by: Petr Vorel <pvorel@suse.cz> > > --- > > testsuite/tests/ip/route/add_default_route.t | 2 ++ > > 1 file changed, 2 insertions(+) > > diff --git a/testsuite/tests/ip/route/add_default_route.t > > b/testsuite/tests/ip/route/add_default_route.t > > index 569ba1f8..c536e35f 100755 > > --- a/testsuite/tests/ip/route/add_default_route.t > > +++ b/testsuite/tests/ip/route/add_default_route.t > > @@ -31,3 +31,5 @@ ts_ip "$0" "Add another IPv6 route dst > > cafe:babe::/64" -6 route add cafe:babe::/ > > ts_ip "$0" "Show IPv6 default route" -6 route show default > > test_on "default via dead:beef::2 dev $DEV" > > test_lines_count 1 > > + > > +ts_ip "$0" "Del $NEW_DEV dummy interface" link del dev $DEV > > Shouldn't this be using $DEV instead of $NEW_DEV? > ts_ip "$0" "Delete $DEV interface" link del dev $DEV > > Copy paste from new_link.t? Ops! Yes indeed, copy-pasta, fixed in v2, thanks.
diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/route/add_default_route.t index 569ba1f8..c536e35f 100755 --- a/testsuite/tests/ip/route/add_default_route.t +++ b/testsuite/tests/ip/route/add_default_route.t @@ -31,3 +31,5 @@ ts_ip "$0" "Add another IPv6 route dst cafe:babe::/64" -6 route add cafe:babe::/ ts_ip "$0" "Show IPv6 default route" -6 route show default test_on "default via dead:beef::2 dev $DEV" test_lines_count 1 + +ts_ip "$0" "Del $NEW_DEV dummy interface" link del dev $DEV
Signed-off-by: Luca Boccassi <bluca@debian.org> --- testsuite/tests/ip/route/add_default_route.t | 2 ++ 1 file changed, 2 insertions(+)