From patchwork Sat Dec 15 15:30:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Boccassi X-Patchwork-Id: 1013944 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=debian.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43HBG41gbtz9sB5 for ; Sun, 16 Dec 2018 02:31:08 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730425AbeLOPbE (ORCPT ); Sat, 15 Dec 2018 10:31:04 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:54621 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730127AbeLOPbE (ORCPT ); Sat, 15 Dec 2018 10:31:04 -0500 Received: by mail-wm1-f65.google.com with SMTP id a62so8342208wmh.4 for ; Sat, 15 Dec 2018 07:31:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z7Wr4wnbUNKW5N2rg7uSRFGXr9/TUARp5iOEsLLfrGY=; b=D90ymNNZgrvtparpNg/Q6x0mEKFtk5L0pzkjlxP62xiw3uKRTpFYJ0smUbMzf6y9in SxvJ6pfjxNzklfAMScvDSuNc9nWnCyiptNloPohLBKqS2CnnXiixdxkiJxTnRK1KjlE3 jpOY4J6fqJ7xe06nKPL7AYKPpSrGe5glrvwf+szaGsLOJISH3SPTBQvKlHDeQMSSsGAr xMXxfhwslsld5HxGyropc3dyMmx1g/69NRBDDKNxDKwH263rD/OqypYy1oHrQucjoBSl eC2h8ocEfjQ+RCGitpZC+bQtscnaIKpxLikGrjx4q6cErE8fdCcr/Zo6eb0Fgn4sxK0k 7Vgg== X-Gm-Message-State: AA+aEWYxQA+s+KfjWBKfz3SCUuD/elxJKThwX4yBXQaFwLMTfg6x4n8l C9ckYTF+2XcFOtKRShCSwEpVFxwx X-Google-Smtp-Source: AFSGD/V5IaFFCBjx4Fmf7cQUT1yu6YcndeYqXZ1aF7HGXdgEz92xDkvyKxZvYDhuXCvKiTBhMYVK3Q== X-Received: by 2002:a1c:b1d5:: with SMTP id a204mr6929124wmf.32.1544887861941; Sat, 15 Dec 2018 07:31:01 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:4441:b71:c640:c3f7]) by smtp.gmail.com with ESMTPSA id l14sm9341429wrp.55.2018.12.15.07.31.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Dec 2018 07:31:01 -0800 (PST) From: Luca Boccassi To: netdev@vger.kernel.org Cc: stephen@networkplumber.org, Luca Boccassi , petr.vorel@gmail.com Subject: [PATCH iproute2 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg Date: Sat, 15 Dec 2018 15:30:49 +0000 Message-Id: <20181215153051.13166-2-bluca@debian.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181215153051.13166-1-bluca@debian.org> References: <20181215153051.13166-1-bluca@debian.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Parallel make from the top level directory fails since tests are at the same time as generate_nlmsg: $ make check -j4 ... cd testsuite && make && make alltests echo "Entering iproute2" && cd iproute2 && make configure && cd ..; Entering iproute2 make -C tools Removing results dir ... make[1]: ./tools/generate_nlmsg: Command not found make[1]: ./tools/generate_nlmsg: Command not found Makefile:64: recipe for target 'ip/netns/set_nsid_batch.t' failed make[1]: *** [ip/netns/set_nsid_batch.t] Error 127 make[1]: ./tools/generate_nlmsg: Command not found make[1]: *** Waiting for unfinished jobs.... Makefile:64: recipe for target 'ip/netns/set_nsid.t' failed make[1]: *** [ip/netns/set_nsid.t] Error 127 Makefile:64: recipe for target 'ip/link/show_dev_wo_vf_rate.t' failed make[1]: *** [ip/link/show_dev_wo_vf_rate.t] Error 127 CC generate_nlmsg Makefile:123: recipe for target 'check' failed make: *** [check] Error 2 Add an explicit dependency in testuite/Makefile's $(TESTS) rule so that the tool correctly gets compiled before any test runs. Fixes: 3537633dcf44 ("testsuite: Generate generate_nlmsg when needed") Cc: petr.vorel@gmail.com Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel Tested-by: Petr Vorel --- testsuite/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/Makefile b/testsuite/Makefile index 46b243b0..9b0f1c15 100644 --- a/testsuite/Makefile +++ b/testsuite/Makefile @@ -53,7 +53,7 @@ clean: testclean distclean: clean echo "Entering iproute2" && cd iproute2 && $(MAKE) distclean && cd ..; -$(TESTS): testclean +$(TESTS): generate_nlmsg testclean ifeq (,$(IPVERS)) $(error Please run make first) endif