From patchwork Sat Dec 15 01:19:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Maciej_=C5=BBenczykowski?= X-Patchwork-Id: 1013790 X-Patchwork-Delegate: linville@tuxdriver.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="j/J2HDvL"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43GqPR4Nd6z9s1c for ; Sat, 15 Dec 2018 12:21:15 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727775AbeLOBTd (ORCPT ); Fri, 14 Dec 2018 20:19:33 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43297 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726448AbeLOBTd (ORCPT ); Fri, 14 Dec 2018 20:19:33 -0500 Received: by mail-pg1-f196.google.com with SMTP id v28so3436697pgk.10 for ; Fri, 14 Dec 2018 17:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4FAPWQ1+BcyK9v2kVDc8jI+wiuo+92OyULkEEAmoGTE=; b=j/J2HDvLAiIjX1vXIoUbRFFwFHaJCP5oPF7QBIRIxCXz6i1RUZ9IaP1ENzuiG3LQN3 7FCsu1YnLBp0/SsUGtXj+8xhNcZB6G5z+fMTP2H+oRRXRlWb7oct0bFj61OraxE4hdl0 VID/25Z8FxF13a1sxlGZvRlQTXwg76WuISl1XkNxZ7+OyW7LYQ8Shkb1uoTnXtNeZZwY PvMNZzA4hG9rA6iJ9JbNMRd3tVhXXFrYO6b+nB6MZU/4s/gGiXvyi6rYiFfioJU/nt0O lJDxG4Ilzb8opEhmjUvsLUPyF38ygoG44gN1Zgf8rLdYLrh+Mz9MUxJvQeAuoDVTF95V /k0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4FAPWQ1+BcyK9v2kVDc8jI+wiuo+92OyULkEEAmoGTE=; b=O4AgdNybbJpqj51RObPIcQGSIwVaa9KOAFQwKTc2zHDZUHEAciPtdUiy6mUs0aILux cN42Gxn4jbGk/g/YZ1WvpjBS+xr5Y3/1F/jTUNsJw+SaQGRz0P5sPBjvJooOBkXoF8Ss KmjFHL8v4CBPllLQIBCkTY3HJorzvsd9I4wLU4d0ryzyTskY2rFSyTf1x4ctHlfa5SmL sEKYy2bLhikF0Z3Ko3gQYXBkrErW34lWd8HUu6PGjvaWGjgWMKmSMJPabwB3S/9u43zj F5+JYoAjGNEdH6eZuoUekiNlxCmx2ljgHoQw8FmHushp1RYG7HzHXCKp0SwAUbn1ACYs Mw/A== X-Gm-Message-State: AA+aEWY2xkRkACC8IU0QOqxPhcAgBw7pZFOHbF9Y0xnHOCyEvqoLswXl T/vuFzLS1n1eBCyzbhpTeeg= X-Google-Smtp-Source: AFSGD/U5tBqgvBfKFiYD9agX80w/Agl88pP1RUvwNHjz2nv5SohFT+1zotXw+1ptzxk6yUQ1cRO16g== X-Received: by 2002:a62:fb07:: with SMTP id x7mr4841427pfm.71.1544836772209; Fri, 14 Dec 2018 17:19:32 -0800 (PST) Received: from athina.mtv.corp.google.com ([2620:0:1000:1601:d7a4:903f:6d6b:ec10]) by smtp.gmail.com with ESMTPSA id i193sm9898491pgc.22.2018.12.14.17.19.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Dec 2018 17:19:31 -0800 (PST) From: =?utf-8?q?Maciej_=C5=BBenczykowski?= To: =?utf-8?q?Maciej_=C5=BBenczykowski?= , Jeff Garzik , Ben Hutchings Cc: "David S . Miller" , David Decotigny , netdev@vger.kernel.org Subject: [PATCH] ethtool: zero initialize coalesce struct Date: Fri, 14 Dec 2018 17:19:23 -0800 Message-Id: <20181215011923.246179-1-zenczykowski@gmail.com> X-Mailer: git-send-email 2.20.0.405.gbc1bbc6f85-goog MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maciej Żenczykowski prior to fetching it from kernel. Otherwise we run the risk of very tail portion of it (dmac field) being left entirely uninitialized, and likely containing some sort of stale data. It seems to likely be some sort of time (a second's counter). Tested: 'ethtool -c eth1' with old kernel now reports 'dmac: 0' where previously it reported some sort of second counter. Signed-off-by: Maciej Żenczykowski --- ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ethtool.c b/ethtool.c index 2f7e96bb58db..465eeecb9318 100644 --- a/ethtool.c +++ b/ethtool.c @@ -2076,7 +2076,7 @@ static int do_gchannels(struct cmd_context *ctx) static int do_gcoalesce(struct cmd_context *ctx) { - struct ethtool_coalesce ecoal; + struct ethtool_coalesce ecoal = {}; int err; if (ctx->argc != 0)