diff mbox series

[mlx5-next] net/mlx5: Continue driver initialization despite debugfs failure

Message ID 20181213111511.27308-1-leon@kernel.org
State Awaiting Upstream, archived
Delegated to: David Miller
Headers show
Series [mlx5-next] net/mlx5: Continue driver initialization despite debugfs failure | expand

Commit Message

Leon Romanovsky Dec. 13, 2018, 11:15 a.m. UTC 
From: Leon Romanovsky <leonro@mellanox.com>

The failure to create debugfs entry is unpleasant event, but not enough
to abort drier initialization. Align the mlx5_core code to debugfs design
and continue execution whenever debugfs_create_dir() successes or not.

Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
It goes to -next and not to -rc, because this issue was forever.
---
 drivers/net/ethernet/mellanox/mlx5/core/main.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

--
2.19.1

Comments

Saeed Mahameed Dec. 17, 2018, 10:39 p.m. UTC | #1 
On Thu, 2018-12-13 at 13:15 +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> The failure to create debugfs entry is unpleasant event, but not
> enough
> to abort drier initialization. Align the mlx5_core code to debugfs
> design
> and continue execution whenever debugfs_create_dir() successes or
> not.
> 
> Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB
> adapters")
> Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> 

Applied to mlx5-next.

Thanks.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index 778995573812..93fa48a7eabb 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -661,11 +661,9 @@  static int mlx5_pci_init(struct mlx5_core_dev *dev, struct mlx5_priv *priv)

 	priv->numa_node = dev_to_node(&dev->pdev->dev);

-	priv->dbg_root = debugfs_create_dir(dev_name(&pdev->dev), mlx5_debugfs_root);
-	if (!priv->dbg_root) {
-		dev_err(&pdev->dev, "Cannot create debugfs dir, aborting\n");
-		return -ENOMEM;
-	}
+	if (mlx5_debugfs_root)
+		priv->dbg_root =
+			debugfs_create_dir(pci_name(pdev), mlx5_debugfs_root);

 	err = mlx5_pci_enable_device(dev);
 	if (err) {