| Message ID | 20181001041029.2334-1-natechancellor@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | dpaa_eth: Remove useless declaration | expand |
> -----Original Message----- > From: Nathan Chancellor [mailto:natechancellor@gmail.com] > Sent: Monday, October 1, 2018 7:10 AM > To: Madalin-cristian Bucur <madalin.bucur@nxp.com>; David S. Miller > <davem@davemloft.net> > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Nathan > Chancellor <natechancellor@gmail.com> > Subject: [PATCH] dpaa_eth: Remove useless declaration > > Clang warns: > > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2734:34: warning: > tentative array definition assumed to have one element > static const struct of_device_id dpaa_match[]; > ^ > 1 warning generated. > > Turns out that since this driver was introduced in commit 9ad1a3749333 > ("dpaa_eth: add support for DPAA Ethernet"), this declaration has been > unused. Remove it to silence the warning. > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > index 84843de25c7b..6e0f47f2c8a3 100644 > --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c > @@ -2731,8 +2731,6 @@ static int dpaa_ingress_cgr_init(struct dpaa_priv > *priv) > return err; > } > > -static const struct of_device_id dpaa_match[]; > - > static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl) > { > u16 headroom; > -- > 2.19.0 Acked-by: Madalin Bucur <madalin.bucur@nxp.com> Thank you
From: Nathan Chancellor <natechancellor@gmail.com> Date: Sun, 30 Sep 2018 21:10:29 -0700 > Clang warns: > > drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2734:34: warning: > tentative array definition assumed to have one element > static const struct of_device_id dpaa_match[]; > ^ > 1 warning generated. > > Turns out that since this driver was introduced in commit 9ad1a3749333 > ("dpaa_eth: add support for DPAA Ethernet"), this declaration has been > unused. Remove it to silence the warning. > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Applied to net-next.
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index 84843de25c7b..6e0f47f2c8a3 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2731,8 +2731,6 @@ static int dpaa_ingress_cgr_init(struct dpaa_priv *priv) return err; } -static const struct of_device_id dpaa_match[]; - static inline u16 dpaa_get_headroom(struct dpaa_buffer_layout *bl) { u16 headroom;
Clang warns: drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2734:34: warning: tentative array definition assumed to have one element static const struct of_device_id dpaa_match[]; ^ 1 warning generated. Turns out that since this driver was introduced in commit 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet"), this declaration has been unused. Remove it to silence the warning. Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 -- 1 file changed, 2 deletions(-)