From patchwork Sun Sep 30 06:44:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Maciej_=C5=BBenczykowski?= X-Patchwork-Id: 976768 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42NGBT5Xlkz9s4s for ; Sun, 30 Sep 2018 16:45:21 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727569AbeI3NQl convert rfc822-to-8bit (ORCPT ); Sun, 30 Sep 2018 09:16:41 -0400 Received: from mail-pf1-f201.google.com ([209.85.210.201]:53523 "EHLO mail-pf1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727496AbeI3NQk (ORCPT ); Sun, 30 Sep 2018 09:16:40 -0400 Received: by mail-pf1-f201.google.com with SMTP id b17-v6so11920522pfo.20 for ; Sat, 29 Sep 2018 23:44:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=STIdnlpIgsK63t3kBjwnnX2IBlvPS2zaQxqM8c7InKs=; b=Ci6cPzdRQJW4jmOV1oAAyJmqgO02MAE7cm6UJYGORdwYUw8WYA9F+MZqgRTKWa834H 6q+P4/yt8pkgS7ftOVT+z9IVhSjwX1Hp3cmrdL/tYFjGBCfIMEnhe+8m9F30EVC2W45c x/Yg3CsiyL1ugdKRUt3cDfvNlJY8GBMcu7DvmTMAQQhoV4l3N1wkUDZz+iBFHmpTi7yW wzW9sHYyeCNP5xKopdrSUWF4BQC7FxrJ/C9aYb0rGwLgfSNGPohFGVRUZzWafwwx4e/U 6tq0QVMvDp7oHJ5+CwbBaj1LHfN333bX0SR6sevRTXFk+5PdkX6HXbUODT8WowXjhinK HznQ== X-Gm-Message-State: ABuFfogViLaTQGxx7WLn3vmi07OON+NFSL3Sy6kF7tvBEzEteiGG7YBE etyY6xahipUTh5eXF4vfEuzCeA== X-Google-Smtp-Source: ACcGV60yDP7cb2y1lz1JsyqvTzPZcdDGvFjKuc5XSUZI8R7jf+MuePstWjFBiQ/X7mzPJcD4CkQim3br X-Received: by 2002:a65:5cc1:: with SMTP id b1-v6mr1256335pgt.82.1538289897607; Sat, 29 Sep 2018 23:44:57 -0700 (PDT) Date: Sat, 29 Sep 2018 23:44:46 -0700 Message-Id: <20180930064454.187537-1-zenczykowski@gmail.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.19.0.605.g01d371f741-goog Subject: [PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset From: "=?UTF-8?q?Maciej=20=C5=BBenczykowski?=" To: "=?UTF-8?q?Maciej=20=C5=BBenczykowski?=" , "David S . Miller" Cc: netdev@vger.kernel.org, David Ahern Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski Reviewed-by: David Ahern --- net/ipv4/route.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index dce2ed66ebe1..02482b71498b 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1217,18 +1217,15 @@ void ip_rt_get_source(u8 *addr, struct sk_buff *skb, struct rtable *rt) src = ip_hdr(skb)->saddr; else { struct fib_result res; - struct flowi4 fl4; - struct iphdr *iph; - - iph = ip_hdr(skb); - - memset(&fl4, 0, sizeof(fl4)); - fl4.daddr = iph->daddr; - fl4.saddr = iph->saddr; - fl4.flowi4_tos = RT_TOS(iph->tos); - fl4.flowi4_oif = rt->dst.dev->ifindex; - fl4.flowi4_iif = skb->dev->ifindex; - fl4.flowi4_mark = skb->mark; + struct iphdr *iph = ip_hdr(skb); + struct flowi4 fl4 = { + .daddr = iph->daddr, + .saddr = iph->saddr, + .flowi4_tos = RT_TOS(iph->tos), + .flowi4_oif = rt->dst.dev->ifindex, + .flowi4_iif = skb->dev->ifindex, + .flowi4_mark = skb->mark, + }; rcu_read_lock(); if (fib_lookup(dev_net(rt->dst.dev), &fl4, &res, 0) == 0)