From patchwork Thu Sep 27 23:00:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Maciej_=C5=BBenczykowski?= X-Patchwork-Id: 975948 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 42LqzC6Dk4z9s4Z for ; Fri, 28 Sep 2018 09:00:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728251AbeI1FVR convert rfc822-to-8bit (ORCPT ); Fri, 28 Sep 2018 01:21:17 -0400 Received: from mail-io1-f73.google.com ([209.85.166.73]:51168 "EHLO mail-io1-f73.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbeI1FVQ (ORCPT ); Fri, 28 Sep 2018 01:21:16 -0400 Received: by mail-io1-f73.google.com with SMTP id z25-v6so4450270iog.17 for ; Thu, 27 Sep 2018 16:00:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc:content-transfer-encoding; bh=GT6l6gKtQOHPWfdP5fH+a19Oz5NEjmzjFzdgFHN1C00=; b=aPzm2M0bo7LBjWxitOh9qDXI8yqIhEfiZizd7iDyyrVPewST3qA5SIBGSWhwbM2dlb O/bf6bhSb/jZgYwkmrfsuvDw9yfPp3fSjFKstPnSY4a+TpYuTRX+zpolgb4yCioCY+Vt 6D8v8D4vfpFV2TUWIOb/FTmFphZWMrI3XM5zTd9V8qUNFGdv2AdcxT8jhhdrWI0Y/Uh8 B4zq9yxMc3lU7gvmNManbPGOOXDfSqiqk2YGxGesremw4FffZBa2G6Ga/O8fNLWxvuN1 1e4xY8KtpyB/Ar9cz07lf/xWpvG4EmkCcnsq00Tr8bM9M5ImtL23kQJxwaeA6et0ns0C is0g== X-Gm-Message-State: ABuFfoi+SVnu3T00fqb16jn6qL+i+5rrRmgQB3Zj8C66+7HNWFkd36AU u/9dXtA75IFCY5viQqS/EWVQmw== X-Google-Smtp-Source: ACcGV61audbOOgS0n7F2J2AREd039NPmw2NbVmqRXvHB0yRMYfK/F8hIcMjk14RsWuvZfOlYy+QnLG4R X-Received: by 2002:a24:400b:: with SMTP id n11-v6mr545333ita.4.1538089237789; Thu, 27 Sep 2018 16:00:37 -0700 (PDT) Date: Thu, 27 Sep 2018 16:00:12 -0700 In-Reply-To: <20180927230017.15398-1-zenczykowski@gmail.com> Message-Id: <20180927230017.15398-6-zenczykowski@gmail.com> Mime-Version: 1.0 References: <20180927230017.15398-1-zenczykowski@gmail.com> X-Mailer: git-send-email 2.19.0.605.g01d371f741-goog Subject: [PATCH 06/11] net: ip6_redirect_no_header() - use new style struct initializer instead of memset From: "=?UTF-8?q?Maciej=20=C5=BBenczykowski?=" To: "=?UTF-8?q?Maciej=20=C5=BBenczykowski?=" , "David S . Miller" Cc: netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index e148d197d628..dd8c04f253d5 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2526,15 +2526,14 @@ void ip6_redirect_no_header(struct sk_buff *skb, struct net *net, int oif, const struct ipv6hdr *iph = ipv6_hdr(skb); const struct rd_msg *msg = (struct rd_msg *)icmp6_hdr(skb); struct dst_entry *dst; - struct flowi6 fl6; - - memset(&fl6, 0, sizeof(fl6)); - fl6.flowi6_iif = LOOPBACK_IFINDEX; - fl6.flowi6_oif = oif; - fl6.flowi6_mark = mark; - fl6.daddr = msg->dest; - fl6.saddr = iph->daddr; - fl6.flowi6_uid = sock_net_uid(net, NULL); + struct flowi6 fl6 = { + .flowi6_iif = LOOPBACK_IFINDEX, + .flowi6_oif = oif, + .flowi6_mark = mark, + .daddr = msg->dest, + .saddr = iph->daddr, + .flowi6_uid = sock_net_uid(net, NULL), + }; dst = ip6_route_redirect(net, &fl6, skb, &iph->saddr); rt6_do_redirect(dst, NULL, skb);