From patchwork Thu Sep 6 21:01:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Raitto X-Patchwork-Id: 967109 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="u5BMIqnN"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 425tKJ1slzz9s3l for ; Fri, 7 Sep 2018 07:01:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729950AbeIGBig (ORCPT ); Thu, 6 Sep 2018 21:38:36 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:42700 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728403AbeIGBig (ORCPT ); Thu, 6 Sep 2018 21:38:36 -0400 Received: by mail-pl1-f194.google.com with SMTP id g23-v6so5520955plq.9 for ; Thu, 06 Sep 2018 14:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9NpIZ+Qfpy5wqur5/GawDrRo25mqz3UBc5UEaBEY/5Y=; b=u5BMIqnNMWGu5tUhXvowvNxi0e6LbhifwjGz6L35cFVyrfE46K2AlisBo1/u240Udt kaoKc5j4jRnL05qDLWqvnO/FwGSgAvWRtZreHc01tFgo5qD0VUz5O+X0yls9Anoc3SA2 SLcHsc1/IQX97WVfgv0RnHMjUozSn1JIWZ28+bMu8WdP523gFQKMGavmzehjryt1uQfM QsMiqw2MPARFCXSvK0xTBy/mOKUX1jL0RYqvB2MdfwSCcUh8bz52dhcxcYsEndAWbG1g GV8ztBfwSYGbHqvhBqhePRV+Kg91ZTjtYiCUM9rca3Ke/ypPRurlvd/14MgTumE2mVuJ LTkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9NpIZ+Qfpy5wqur5/GawDrRo25mqz3UBc5UEaBEY/5Y=; b=Jg+qzibIpo1V/2asfaiwgdgVvmKmGE+PqKNrib/ougQX8mb043DivCICzNe7Y89qqe /MZwwILJYA1xmLhmybSmxdqFi02cC1DDyUfM2LU8ngBqvzcAITb4G+40x3PzQpmf9v+H vrHdgJvS9URsqAj6+z+rnG3Ai0cSmMnFrLpseiGqjBbCjE3K7WtW1QXEG7PUCCYQRsxp Mtnwjp4xEfndWaG6gHnOnRLgQaqf6T3/jwxFnpWTOpDAQhegA9rnLJQaUkUOAOWtrAdw Bbjk+fGNcvZlmluL7gAO/sLF2gXe33FcmXkK7h6HANCqMw6SNie6OTOoV581xFbrq46U p7YA== X-Gm-Message-State: APzg51AHkwnOUWHC5IW3mLo+LnZCv9DxZX3VDm0ZapDPVsE8S1SEWxgk aayWqKt0Bn908wHDnfIktKs= X-Google-Smtp-Source: ANB0Vdb3t9BDq11NSCwvfQg1iQL56MytxnYyFQZFh+HC2VQU0HfK08hTW3TqFqwJagx8VT64RDHzjA== X-Received: by 2002:a17:902:b115:: with SMTP id q21-v6mr4681703plr.333.1536267681275; Thu, 06 Sep 2018 14:01:21 -0700 (PDT) Received: from caraitto-dev.sea.corp.google.com ([2620:0:1009:11:84ae:3ba4:ea4b:7d69]) by smtp.gmail.com with ESMTPSA id s16-v6sm7343961pfm.114.2018.09.06.14.01.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Sep 2018 14:01:20 -0700 (PDT) From: Caleb Raitto To: stephen@networkplumber.org, netdev@vger.kernel.org Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, Caleb Raitto Subject: [PATCH iproute2 v2] tc/mqprio: Print extra info on invalid args. Date: Thu, 6 Sep 2018 14:01:17 -0700 Message-Id: <20180906210117.203461-1-caleb.raitto@gmail.com> X-Mailer: git-send-email 2.19.0.rc2.392.g5ba43deb5a-goog MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Caleb Raitto Print the name of the argument that wasn't understood. Signed-off-by: Caleb Raitto --- tc/q_mqprio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tc/q_mqprio.c b/tc/q_mqprio.c index 89b46002..7cd18ae1 100644 --- a/tc/q_mqprio.c +++ b/tc/q_mqprio.c @@ -167,8 +167,7 @@ static int mqprio_parse_opt(struct qdisc_util *qu, int argc, explain(); return -1; } else { - fprintf(stderr, "Unknown argument\n"); - return -1; + invarg("unknown argument", *argv); } argc--; argv++; }