| Message ID | 20180816090220.4537-1-yuval.shaia@oracle.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v3] net/mlx5e: Delete unneeded function argument | expand |
On Thu, Aug 16, 2018 at 12:02:20PM +0300, Yuval Shaia wrote: > priv argument is not used by the function, delete it. > > Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> > --- > v1 -> v2: > * Remove blank line as pointed by Leon. > > v2 -> v3: > * Change prefix to mlx5e > --- > drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks Yuval, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
From: Yuval Shaia <yuval.shaia@oracle.com> Date: Thu, 16 Aug 2018 12:02:20 +0300 > priv argument is not used by the function, delete it. > > Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> > --- > v1 -> v2: > * Remove blank line as pointed by Leon. > > v2 -> v3: > * Change prefix to mlx5e Applied, thank you.
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c index 1646859974ce..4c4d779dafa8 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c @@ -813,7 +813,7 @@ static const struct counter_desc pport_per_prio_traffic_stats_desc[] = { #define NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS ARRAY_SIZE(pport_per_prio_traffic_stats_desc) -static int mlx5e_grp_per_prio_traffic_get_num_stats(struct mlx5e_priv *priv) +static int mlx5e_grp_per_prio_traffic_get_num_stats(void) { return NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS * NUM_PPORT_PRIO; } @@ -971,7 +971,7 @@ static int mlx5e_grp_per_prio_pfc_fill_stats(struct mlx5e_priv *priv, static int mlx5e_grp_per_prio_get_num_stats(struct mlx5e_priv *priv) { - return mlx5e_grp_per_prio_traffic_get_num_stats(priv) + + return mlx5e_grp_per_prio_traffic_get_num_stats() + mlx5e_grp_per_prio_pfc_get_num_stats(priv); }
priv argument is not used by the function, delete it. Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups") Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> --- v1 -> v2: * Remove blank line as pointed by Leon. v2 -> v3: * Change prefix to mlx5e --- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)