diff mbox series

[net-next] net: report netlink extack only if set

Message ID 20180805194801.173032-1-willemdebruijn.kernel@gmail.com
State Not Applicable, archived
Delegated to: David Miller
Headers show
Series [net-next] net: report netlink extack only if set | expand

Commit Message

Willem de Bruijn Aug. 5, 2018, 7:48 p.m. UTC 
From: Willem de Bruijn <willemb@google.com>

Initialize extack in dev_set_mtu and report only if set.

Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
---
 net/core/dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Miller Aug. 6, 2018, 12:37 a.m. UTC | #1 
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Date: Sun,  5 Aug 2018 15:48:01 -0400

> From: Willem de Bruijn <willemb@google.com>
> 
> Initialize extack in dev_set_mtu and report only if set.
> 
> Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
> Reported-by: syzbot <syzkaller@googlegroups.com>
> Signed-off-by: Willem de Bruijn <willemb@google.com>

Someone beat you to it :-)  And that version is in net-next.

Thanks!
Willem de Bruijn Aug. 6, 2018, 1:40 a.m. UTC | #2 
On Sun, Aug 5, 2018 at 8:37 PM David Miller <davem@davemloft.net> wrote:
>
> From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Date: Sun,  5 Aug 2018 15:48:01 -0400
>
> > From: Willem de Bruijn <willemb@google.com>
> >
> > Initialize extack in dev_set_mtu and report only if set.
> >
> > Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
> > Reported-by: syzbot <syzkaller@googlegroups.com>
> > Signed-off-by: Willem de Bruijn <willemb@google.com>
>
> Someone beat you to it :-)  And that version is in net-next.

Oops. I had totally missed that thread. Glad to see it's fixed already.
diff mbox series

Patch

diff --git a/net/core/dev.c b/net/core/dev.c
index 36e994519488e..1d0122a766019 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -7580,11 +7580,11 @@  int dev_set_mtu_ext(struct net_device *dev, int new_mtu,
 
 int dev_set_mtu(struct net_device *dev, int new_mtu)
 {
-	struct netlink_ext_ack extack;
+	struct netlink_ext_ack extack = {};
 	int err;
 
 	err = dev_set_mtu_ext(dev, new_mtu, &extack);
-	if (err)
+	if (err && extack._msg)
 		net_err_ratelimited("%s: %s\n", dev->name, extack._msg);
 	return err;
 }