diff mbox series

[net-next,v2,1/2] tls: Remove dead code in tls_sw_sendmsg

Message ID 20180726145936.3547913-2-doronrk@fb.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series tls: Fix improper revert in zerocopy_from_iter | expand

Commit Message

Doron Roberts-Kedes July 26, 2018, 2:59 p.m. UTC 
tls_push_record either returns 0 on success or a negative value on failure.
This patch removes code that would only be executed if tls_push_record
were to return a positive value.

Signed-off-by: Doron Roberts-Kedes <doronrk@fb.com>
---
 net/tls/tls_sw.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index 03f1370f5db1..0279bc4a168b 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -423,12 +423,10 @@  int tls_sw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size)
 
 			copied += try_to_copy;
 			ret = tls_push_record(sk, msg->msg_flags, record_type);
-			if (!ret)
-				continue;
-			if (ret < 0)
+			if (ret)
 				goto send_end;
+			continue;
 
-			copied -= try_to_copy;
 fallback_to_reg_send:
 			iov_iter_revert(&msg->msg_iter,
 					ctx->sg_plaintext_size - orig_size);