| Message ID | 20180725152227.GA26303@embeddedor.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | rds: send: Fix dead code in rds_sendmsg | expand |
On (07/25/18 10:22), Gustavo A. R. Silva wrote: > Currently, code at label *out* is unreachable. Fix this by updating > variable *ret* with -EINVAL, so the jump to *out* can be properly > executed instead of directly returning from function. > > Addresses-Coverity-ID: 1472059 ("Structurally dead code") > Fixes: 1e2b44e78eea ("rds: Enable RDS IPv6 support") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
On 7/25/2018 8:22 AM, Gustavo A. R. Silva wrote: > Currently, code at label *out* is unreachable. Fix this by updating > variable *ret* with -EINVAL, so the jump to *out* can be properly > executed instead of directly returning from function. > > Addresses-Coverity-ID: 1472059 ("Structurally dead code") > Fixes: 1e2b44e78eea ("rds: Enable RDS IPv6 support") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- Looks fine. Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> Date: Wed, 25 Jul 2018 10:22:27 -0500 > Currently, code at label *out* is unreachable. Fix this by updating > variable *ret* with -EINVAL, so the jump to *out* can be properly > executed instead of directly returning from function. > > Addresses-Coverity-ID: 1472059 ("Structurally dead code") > Fixes: 1e2b44e78eea ("rds: Enable RDS IPv6 support") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied.
diff --git a/net/rds/send.c b/net/rds/send.c index 9604e1f..18e2b4d 100644 --- a/net/rds/send.c +++ b/net/rds/send.c @@ -1126,7 +1126,7 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len) if (addr4 == htonl(INADDR_ANY) || addr4 == htonl(INADDR_BROADCAST) || IN_MULTICAST(ntohl(addr4))) { - return -EINVAL; + ret = -EINVAL; goto out; } }
Currently, code at label *out* is unreachable. Fix this by updating variable *ret* with -EINVAL, so the jump to *out* can be properly executed instead of directly returning from function. Addresses-Coverity-ID: 1472059 ("Structurally dead code") Fixes: 1e2b44e78eea ("rds: Enable RDS IPv6 support") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- net/rds/send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)