| Message ID | 20180725140724.GA23053@embeddedor.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: sched: cls_api: fix dead code in switch | expand |
Wed, Jul 25, 2018 at 04:07:24PM CEST, gustavo@embeddedor.com wrote: >Code at line 1850 is unreachable. Fix this by removing the break >statement above it, so the code for case RTM_GETCHAIN can be >properly executed. > >Addresses-Coverity-ID: 1472050 ("Structurally dead code") >Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi") >Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Acked-by: Jiri Pirko <jiri@mellanox.com> I'm just writing a selftest to test this path. Thanks.
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> Date: Wed, 25 Jul 2018 09:07:24 -0500 > Code at line 1850 is unreachable. Fix this by removing the break > statement above it, so the code for case RTM_GETCHAIN can be > properly executed. > > Addresses-Coverity-ID: 1472050 ("Structurally dead code") > Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied, thanks. Please use "[PATCH net-next] ..." in your subject lines to indirect the tree that this change is relevant for and targetted to. Thank you.
On 07/26/2018 04:10 PM, David Miller wrote: > From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> > Date: Wed, 25 Jul 2018 09:07:24 -0500 > >> Code at line 1850 is unreachable. Fix this by removing the break >> statement above it, so the code for case RTM_GETCHAIN can be >> properly executed. >> >> Addresses-Coverity-ID: 1472050 ("Structurally dead code") >> Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi") >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Applied, thanks. > > Please use "[PATCH net-next] ..." in your subject lines to indirect > the tree that this change is relevant for and targetted to. > Got it. Will do next time. Thanks -- Gustavo
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 5f7098b..f3d78c2 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -1846,7 +1846,6 @@ static int tc_ctl_chain(struct sk_buff *skb, struct nlmsghdr *n, tcf_chain_put_explicitly_created(chain); break; case RTM_GETCHAIN: - break; err = tc_chain_notify(chain, skb, n->nlmsg_seq, n->nlmsg_seq, n->nlmsg_type, true); if (err < 0)
Code at line 1850 is unreachable. Fix this by removing the break statement above it, so the code for case RTM_GETCHAIN can be properly executed. Addresses-Coverity-ID: 1472050 ("Structurally dead code") Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- net/sched/cls_api.c | 1 - 1 file changed, 1 deletion(-)