diff mbox series

[iproute2] devlink: CTRL_ATTR_FAMILY_ID is a u16

Message ID 20180720163526.756-1-dsahern@kernel.org
State Accepted, archived
Delegated to: stephen hemminger
Headers show
Series [iproute2] devlink: CTRL_ATTR_FAMILY_ID is a u16 | expand

Commit Message

David Ahern July 20, 2018, 4:35 p.m. UTC 
From: David Ahern <dsahern@gmail.com>

CTRL_ATTR_FAMILY_ID is a u16, not a u32. Update devlink accordingly.

Fixes: a3c4b484a1edd ("add devlink tool")
Signed-off-by: David Ahern <dsahern@gmail.com>
---
 devlink/mnlg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger July 23, 2018, 8:51 p.m. UTC | #1 
On Fri, 20 Jul 2018 09:35:26 -0700
dsahern@kernel.org wrote:

> From: David Ahern <dsahern@gmail.com>
> 
> CTRL_ATTR_FAMILY_ID is a u16, not a u32. Update devlink accordingly.
> 
> Fixes: a3c4b484a1edd ("add devlink tool")
> Signed-off-by: David Ahern <dsahern@gmail.com>

Applied
diff mbox series

Patch

diff --git a/devlink/mnlg.c b/devlink/mnlg.c
index c33c90be4414..37cc25ddf490 100644
--- a/devlink/mnlg.c
+++ b/devlink/mnlg.c
@@ -199,7 +199,7 @@  int mnlg_socket_group_add(struct mnlg_socket *nlg, const char *group_name)
 
 	nlh = __mnlg_msg_prepare(nlg, CTRL_CMD_GETFAMILY,
 				 NLM_F_REQUEST | NLM_F_ACK, GENL_ID_CTRL, 1);
-	mnl_attr_put_u32(nlh, CTRL_ATTR_FAMILY_ID, nlg->id);
+	mnl_attr_put_u16(nlh, CTRL_ATTR_FAMILY_ID, nlg->id);
 
 	err = mnlg_socket_send(nlg, nlh);
 	if (err < 0)