| Message ID | 20180716130009.1591379-1-Haakon.Bugge@oracle.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net/rds: void function cannot return -1 | expand |
On 7/16/2018 6:00 AM, Håkon Bugge wrote: > Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did > not change the comment accordingly. > > Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> > --- > net/rds/ib_recv.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c > index b4e421aa9727..e5ce93419263 100644 > --- a/net/rds/ib_recv.c > +++ b/net/rds/ib_recv.c > @@ -376,8 +376,6 @@ static void release_refill(struct rds_connection *conn) > * This tries to allocate and post unused work requests after making sure that > * they have all the allocations they need to queue received fragments into > * sockets. > - * > - * -1 is returned if posting fails due to temporary resource exhaustion. > */ > void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp) > { > Yep. Thanks !! Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.ccom>
From: Håkon Bugge <Haakon.Bugge@oracle.com> Date: Mon, 16 Jul 2018 15:00:09 +0200 > Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did > not change the comment accordingly. > > Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") > Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> Applied.
diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index b4e421aa9727..e5ce93419263 100644 --- a/net/rds/ib_recv.c +++ b/net/rds/ib_recv.c @@ -376,8 +376,6 @@ static void release_refill(struct rds_connection *conn) * This tries to allocate and post unused work requests after making sure that * they have all the allocations they need to queue received fragments into * sockets. - * - * -1 is returned if posting fails due to temporary resource exhaustion. */ void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp) {
Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did not change the comment accordingly. Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com> --- net/rds/ib_recv.c | 2 -- 1 file changed, 2 deletions(-)