diff mbox series

[v2,net-next] net: Use __u32 in uapi net_stamp.h

Message ID 20180709232056.15452-1-jesus.sanchez-palencia@intel.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series [v2,net-next] net: Use __u32 in uapi net_stamp.h | expand

Commit Message

Jesus Sanchez-Palencia July 9, 2018, 11:20 p.m. UTC
We are not supposed to use u32 in uapi, so change the flags member of
struct sock_txtime from u32 to __u32 instead.

Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time")
Reported-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
---
 include/uapi/linux/net_tstamp.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Eric Dumazet July 9, 2018, 11:29 p.m. UTC | #1
On 07/09/2018 04:20 PM, Jesus Sanchez-Palencia wrote:
> We are not supposed to use u32 in uapi, so change the flags member of
> struct sock_txtime from u32 to __u32 instead.
> 
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time")
> Reported-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks !
David Miller July 9, 2018, 11:31 p.m. UTC | #2
From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
Date: Mon,  9 Jul 2018 16:20:56 -0700

> We are not supposed to use u32 in uapi, so change the flags member of
> struct sock_txtime from u32 to __u32 instead.
> 
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time")
> Reported-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>

Applied.
diff mbox series

Patch

diff --git a/include/uapi/linux/net_tstamp.h b/include/uapi/linux/net_tstamp.h
index f8f4539f1135..97ff3c17ec4d 100644
--- a/include/uapi/linux/net_tstamp.h
+++ b/include/uapi/linux/net_tstamp.h
@@ -155,8 +155,8 @@  enum txtime_flags {
 };
 
 struct sock_txtime {
-	clockid_t       clockid;        /* reference clockid */
-	u32             flags;          /* flags defined by enum txtime_flags */
+	clockid_t	clockid;	/* reference clockid */
+	__u32		flags;		/* as defined by enum txtime_flags */
 };
 
 #endif /* _NET_TIMESTAMPING_H */