From patchwork Fri Jun 8 09:20:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Vecera X-Patchwork-Id: 926651 X-Patchwork-Delegate: linville@tuxdriver.com Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cera.cz Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 412H2D5jLxz9s01 for ; Fri, 8 Jun 2018 19:20:36 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751128AbeFHJUQ (ORCPT ); Fri, 8 Jun 2018 05:20:16 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40032 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751072AbeFHJUO (ORCPT ); Fri, 8 Jun 2018 05:20:14 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 26097406E8C0; Fri, 8 Jun 2018 09:20:14 +0000 (UTC) Received: from ceranb.redhat.com (unknown [10.40.205.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 955591116701; Fri, 8 Jun 2018 09:20:11 +0000 (UTC) From: Ivan Vecera To: linville@tuxdriver.com Cc: netdev@vger.kernel.org Subject: [PATCH ethtool 1/6] ethtool: fix uninitialized return value Date: Fri, 8 Jun 2018 11:20:05 +0200 Message-Id: <20180608092010.13041-1-cera@cera.cz> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 08 Jun 2018 09:20:14 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 08 Jun 2018 09:20:14 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cera@cera.cz' RCPT:'' Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes: b0fe96d ("Ethtool: Implements ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE and PHY downshift") Signed-off-by: Ivan Vecera --- ethtool.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ethtool.c b/ethtool.c index 2e87384..e7495fe 100644 --- a/ethtool.c +++ b/ethtool.c @@ -4723,8 +4723,8 @@ static int do_get_phy_tunable(struct cmd_context *ctx) { int argc = ctx->argc; char **argp = ctx->argp; - int err, i; u8 downshift_changed = 0; + int i; if (argc < 1) exit_bad_args(); @@ -4750,8 +4750,7 @@ static int do_get_phy_tunable(struct cmd_context *ctx) cont.ds.id = ETHTOOL_PHY_DOWNSHIFT; cont.ds.type_id = ETHTOOL_TUNABLE_U8; cont.ds.len = 1; - err = send_ioctl(ctx, &cont.ds); - if (err < 0) { + if (send_ioctl(ctx, &cont.ds) < 0) { perror("Cannot Get PHY downshift count"); return 87; } @@ -4762,7 +4761,7 @@ static int do_get_phy_tunable(struct cmd_context *ctx) fprintf(stdout, "Downshift disabled\n"); } - return err; + return 0; } static __u32 parse_reset(char *val, __u32 bitset, char *arg, __u32 *data)