| Message ID | 20180604144601.wo5iqb5irfes4frv@kili.mountain |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [1/2,v2,net-next] net_failover: Use netdev_features_t instead of u32 | expand |
Mon, Jun 04, 2018 at 04:46:01PM CEST, dan.carpenter@oracle.com wrote: >This code was introduced in 2011 around the same time that we made >netdev_features_t a u64 type. These days a u32 is not big enough to >hold all the potential features. > >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Jiri Pirko <jiri@mellanox.com>
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Mon, 4 Jun 2018 17:46:01 +0300 > This code was introduced in 2011 around the same time that we made > netdev_features_t a u64 type. These days a u32 is not big enough to > hold all the potential features. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied and queued up for -stable.
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 267dcc929f6c..8863fa023500 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -1004,7 +1004,8 @@ static void team_port_disable(struct team *team, static void __team_compute_features(struct team *team) { struct team_port *port; - u32 vlan_features = TEAM_VLAN_FEATURES & NETIF_F_ALL_FOR_ALL; + netdev_features_t vlan_features = TEAM_VLAN_FEATURES & + NETIF_F_ALL_FOR_ALL; netdev_features_t enc_features = TEAM_ENC_FEATURES; unsigned short max_hard_header_len = ETH_HLEN; unsigned int dst_release_flag = IFF_XMIT_DST_RELEASE |
This code was introduced in 2011 around the same time that we made netdev_features_t a u64 type. These days a u32 is not big enough to hold all the potential features. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>