Message ID | 20180518075850.GA28335@mwanda |
---|---|
State | Superseded, archived |
Delegated to: | BPF Maintainers |
Headers | show |
Series | [1/2] bpf: sockmap, double free in __sock_map_ctx_update_elem() | expand |
diff --git a/kernel/bpf/sockmap.c b/kernel/bpf/sockmap.c index c6de1393df63..6298adb3162a 100644 --- a/kernel/bpf/sockmap.c +++ b/kernel/bpf/sockmap.c @@ -1821,7 +1821,7 @@ static int __sock_map_ctx_update_elem(struct bpf_map *map, list_add_tail(&e->list, &psock->maps); } write_unlock_bh(&sock->sk_callback_lock); - return err; + return 0; out_free: kfree(e); smap_release_sock(psock, sock);
Smatch complains that "err" might be uninitialized. That seems possible. Anyway we can just return zero. Fixes: e5cd3abcb31a ("bpf: sockmap, refactor sockmap routines to work with hashmap") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>