From patchwork Sun May 13 17:54:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kalderon X-Patchwork-Id: 912546 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cavium.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="M6Or4PbI"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40kWgj03sBz9s0y for ; Mon, 14 May 2018 03:54:56 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751893AbeEMRyu (ORCPT ); Sun, 13 May 2018 13:54:50 -0400 Received: from mail-co1nam03on0082.outbound.protection.outlook.com ([104.47.40.82]:48288 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751881AbeEMRyr (ORCPT ); Sun, 13 May 2018 13:54:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=g7cUNRcN1cGOSosicE/p7EGraJZ8dRs330jLjGc5Isg=; b=M6Or4PbIr5j+40ibOYRNUDKUVlo/cC3oZdw9h3VdFCBwgDRf5KES86+441u1vp0IO6oKcAQH1wNNc1K4fHct4rVtKCYIXGbnIN1zmUC+ceLzYQdvwkNX5Q2ddHcH2fF8UTCMc8jfJKMRL4PvBKJikmtT8g9vDOm9kLvDpmvyTXA= Received: from DM5PR07CA0080.namprd07.prod.outlook.com (2603:10b6:4:ad::45) by SN1PR07MB3917.namprd07.prod.outlook.com (2603:10b6:802:24::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.755.16; Sun, 13 May 2018 17:54:45 +0000 Received: from BL2FFO11OLC001.protection.gbl (2a01:111:f400:7c09::101) by DM5PR07CA0080.outlook.office365.com (2603:10b6:4:ad::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.755.16 via Frontend Transport; Sun, 13 May 2018 17:54:45 +0000 Authentication-Results: spf=pass (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=cavium.com; Received-SPF: Pass (protection.outlook.com: domain of cavium.com designates 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11OLC001.mail.protection.outlook.com (10.173.161.185) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.735.16 via Frontend Transport; Sun, 13 May 2018 17:54:44 +0000 Received: from lb-tlvb-michal.il.qlogic.com.com (10.185.6.89) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Sun, 13 May 2018 10:54:42 -0700 From: Michal Kalderon To: , CC: , , , Michal Kalderon , Ariel Elior Subject: [PATCH net] qede: Fix ref-cnt usage count Date: Sun, 13 May 2018 20:54:06 +0300 Message-ID: <20180513175406.21350-1-Michal.Kalderon@cavium.com> X-Mailer: git-send-email 2.14.3 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(346002)(396003)(39850400004)(376002)(2980300002)(438002)(199004)(189003)(104016004)(106002)(106466001)(1076002)(16586007)(2906002)(51416003)(69596002)(305945005)(4326008)(186003)(107886003)(26005)(54906003)(110136005)(356003)(47776003)(86362001)(77096007)(486006)(8676002)(476003)(126002)(336012)(81156014)(81166006)(36756003)(50466002)(2616005)(50226002)(478600001)(48376002)(316002)(5660300001)(72206003)(8936002)(6666003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR07MB3917; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Pass; LANG:en; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC001; 1:yVCSRcrMl1I8CS3tBwh/WoQPHdmcuSj7BcOh66CHJjFBFou9/f5qHndCV/euVpMmGQfa3W0dZXx1O/PAzIf4vvaMFDl18m02TefcG5uX42Vw2yIf8spqJXEaRCOd2lz8 X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4608076)(2017052603328)(7153060); SRVR:SN1PR07MB3917; X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB3917; 3:g3Py3BZCcHVt+LfvfVdQrbbGbe16+RuhAogUGd528fhONviAZ6xkYQdRifryZjnTDQoHO8J3XuDqKZ9vhyORpSnteWazcn/M0RLBV0rMELK6sic8aoC5R93oEWLCVHDfWm470DCAd+K5z7Luvb5NkS/3DScJJmUfHOs5eAFd07YtQeYTXQFfAuo7QHP3TvwQOBzmhrzNHU9oIiWFyYw8RAOCskT8sldO6OsMv8Z4g+//fxAM2c+iX/SHsrisexoQ34jE1f5DGtifxAXxjj5BBzZDLKjLYamBAMrMrux98p5Q7AbTl19SgI6tKC06EBA2jKE7/QpZsYbtcF4VjP0emN9HFoY22NU/HSCQ5OZbun8=; 25:N8hySKr3ePlZo0Ko6cX7O4Q1qGBpRS/N3gwriEzHFDn2ZIdJAZsAKWDiN2bi9fks2eQ5UocaysSpwwnHbDM3O5LJxuhJEYM4+Jy4EK3Efi4yTt+WIU2Q1p2Ldwf2Gv9TrEkrsrMAreGyeIYH7LAmOLQz7GAwGDLjXQ8sALiPSXcM/igSQhU7ufAa3OxEpF3m5kjNV/gpjKYfl9wuENbySYUmmCZBy/2YXT5EEeVAjcPzUXkAtdyM++1NvUtOKx/Fy5oxugc/yYf0cKGot9xdfurEAPjgxXQy4EYImkSAiVc6uCz+MZeIteOL3oKBxYm+dyka/w8VFiAVYsPcrzlOyg== X-MS-TrafficTypeDiagnostic: SN1PR07MB3917: X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB3917; 31:cBMwgUO04+6nYFAQ1KdQAK4rvGajiv/1RbWHZyq6mDdj1pN87/J3ldveXvhNZfjY5Biu8L5GIeXTHb4nsb8efugDI1fAVs7xovMK+WvHhdtPV7e4nTiTIaHYO0pqsZ5OmPAG7VBM600EpsYFPxBjJ/Q/Ii7JP+qwOw6IexhkbVzqQpYhWSx6r6hz+QSehlxV7+LqkMX79AqTMc7N0u99ZdNuqOTSaTuiajJRqkLnAaQ=; 20:iZuwBf+7iZUiqsuizniO5w8NWHdVkXGBRt1pIbDh84Q4fAjaHiqKxd+5qkWqrsMe/PCuD6wcXWqD5ZUlGPizeqLaaTSB3EWkHl9fYVskJESOgtPXrwemoNRU8sZsVUxxOHeVT/bctdGH0Fv0Ft9fPWBmq/yuWvu1OMCNvdWs/bOLVvaQ6NxuiGJAeknvIEENVbvJiy6vnCDac1uudBD8td70aWr7xyhXQP1W81Uu8cSOP7CVC5wMCAuENNQ3C/ISDtgQv68GNLEQvKbTQaMn8qcZdOwzlD6rXzxxI/2muq/ZLy6jTybHeM/lHHJRn4Im6/lz7ERXmWcUs4ZL8SXCyAhOvVLDSX6OurUcqfr5P0ZKPvcbLlvcYMPeo1J97wkAIm1gAdp3mV63z2UXb7JWLBpZ4mV8/w+aUbJUNoisIAk2NwLQeP0AI1Pn148iDfyZlfu7rFaRsHHm7p97oy5EUVPD4wSn0fbpDn1kYiSI4XaB+c3vdyriXtYzJCqY+0+U X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93004095)(3231254)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:SN1PR07MB3917; BCL:0; PCL:0; RULEID:; SRVR:SN1PR07MB3917; X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB3917; 4:RWloCU6uMLWxBRsX2C2yl+DsNgAnHxw297j6OkEUjQQL/m9TgBJoQ0uKwJT7npGKmFMEcqe3JVswbrsHXDTzXURm3jXQQkQOKdvnCQrMzAC1d6G5vjZb5sFQ8FVqd3twpDqmSWnpldpbsVauNKgUGhbWbFRDCcOxelPnBljDzufkGimFw4Q6muhCjYa0Q5uS6L03nKpnNNu8YDOc5va9HfLMC7zlmWZeR5hxHluerUCVHatdJtKyarNK0gguRWWFegmRbiv/a7qW6MhFH9Al9A== X-Forefront-PRVS: 0671F32598 X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB3917; 23:EkLGUEqpRSbKZDYxbcFlqi6VkYOQm1h7s447qO7pqUbaK0jUXAnopHzdczcSuVSOcB6vKIfsxYbTpcgaGjejXGdXrnyIXi06ZHw+u9h4ZltIXjNeh6B1ESMP940YTLGsQ7X4c3jk/6ksvI6ivBSUGhK7vgLkzZTWPQS4ZOSFz9Z95gCeEDJGWUDLZAAw/hLiu42JF21T/GBW5Tt7nMwKH4yNN68E0OaLqwRCHR4vJusdPHjor6tySKUo4C1eRoHW96w8AgVAKZoRxvXpd9SFsA3qgq+EG6inwvupEKj6v6ektMAU1gdw9uiaeko4F44iS5LD0NxBX+mY8I2VkW9VxcqZA3WBokBkXEb74reFMouz9A1fS3xWVgKOdEprLB6CIaJbKohl5822ZGgxzmOhRzbk7gqXIykEfqB9Hc7HPN4d+mDdo5NMBfXVmjOzpE3WVYV4F44ON//I4VeC85LqOpiZmqU9twwkej0RAQIotYWFeuMO6agrxagNcto7u6F0neAFaEGh1O9EIlZu29wUwc5/F9ZG53cpGk4+DYL6UmcLoSQm2ErIGZmDyAnjzvwY/N6TYFnt+ValIWKSvT6FBFc7kieO/TkDNG1KNpit2OwJggseCYzwlTuxq0sNd7xfNZqsiA0+WcQbYf4s+pp18aI1g07qW05oAFd/kVlSVmtw/t2srk5Z/VVrBG2xcNyE/6hxwFGWMl9KmT9ZHWyd2oSdsMEURsbw0kzX0M6Tv7Ql7sPlyrB6YsGHR8iwRuACnlDt3g6R9Ltx1VdaczC1uBXdR0i76PUTNK5wzNlQw5WejY2lImENK7BBsRQjcozDuO6K2wnb0Del/rxuXCvotv9jrWhTV9J72GBUWm+o71JQqCvheFEgHMhInhUExxpTrC6iOLMYWDrEehXfOiebiROVTjd2iEg0Ohag52XTOGciP9FXuyKeEcuM530hxoUjNOZgsPezkobqGQ67maJIUdJs+oKfX8jajwXa/Mee4Fq3MBYYaS6T5Ktbaj/OtjXqsANVru7xlpV106Zn2g88JWWoIKcs13yh2JnrwcbaZtg= X-Microsoft-Antispam-Message-Info: N6K9Ubv9E0oWpWGToVzq/Ea+VVBH+ssqoL1gQSzSBhnHIX1Hv9zvpoCYJa5e2Gwdt+Lfq82jgDoxhgqovt2W9d78+JpuO29e9Np5ZXX0yRka3/uB89+jDtjFwo/MpEOTv3DzlFU9GTkmpfy6jOZTillYZJPKJ67128IU61G7Hexf37BRlCdRnGMaHtnvq4Px X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB3917; 6:CE2ddae9CZiDkLsa2ESLZOdRa9j299rBsoUBUd4tmrTJWBbeQYBxUfyRl9FrfdH19nSFHwpSMSxDKvAA/iHm/I+spVpDk9tz9T6GsW70BYUQQwmoN+2BqGbMJO7jaam+S84E7mjKmc9afXC1OQZ43XL8n+roSzUxUUj/3tskqvF/eFm4tbH3IGqDhKW33VJlZneUdpZ2UAhPvz/yxJNL5YA0XjBmf/goFoGZi4ko8QVP4nk9Ycu7IJUhacm/MHvWDGvPXcFIZg7ojKFlpHjzpMp2NTt07lbVAXL6PtkjlBGSs/piFWpluvCf/FnrQz4wxuyYGbrGsRlHA78OG5AoJldgRGltUF5dRD5iURL4uK+nSovjjwzg+z6iTu6zACchfKPoJfTX+kEPtdkAKUqlQnojPWqiSvS5mPrZl3YFKy2TZ57xmhHcSWyvu4TMyVx0er6udhd8Q1FOoQlI2qzCbg==; 5:n2ZjuJRohVRHw38dVfZAyER9kLg09/E+b32W9O0Dlj/MRUBIsYTuwn8y3Q68ujqDn/FaddJMb+1ZCyUe4OJD40RgWeOWeLCDUTBoNGX0ZU5fgUJsHo4DcTkDG5fdVPtLiSSfZA0XZVt2GW6JUtmqDf35852QT36w1CKkEv/ZSb0=; 24:VqQ34kCO1lu6eIEK6SP2jD8PwD7oW1nRvbpbXc4FuZQXm6bPaLKdQSsp07MFAqDeADGoMI7Uhudf3QZGwOkavIwSZa+TAcMfuXIIdJbikLw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR07MB3917; 7:9EX/5BYZgdDZulqWJfgSLfdXdSI4i3CEO8mPkJqJ7pvU0DmaAuajlbbdwzj2iNT9MIb11k+FTxov8pNnSXmnnpuCTTA88+03DkixEAY+YgiBWeyalOffT+6+fUW6meYfJSSWYiETGFHySAc6HL5LeeOUKH/Tv6p52ebi99jIHLTV5t0eTVPasjZRbR2gvh8S1cRhEB7fDl0EOuXB6B9lhy48sVykuhUthENpf3vj9GpRbtmNjZqTe3TzXZEeSOCG X-MS-Office365-Filtering-Correlation-Id: cf01b05b-a3e5-4624-da48-08d5b8fa9caf X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2018 17:54:44.9310 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf01b05b-a3e5-4624-da48-08d5b8fa9caf X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR07MB3917 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Rebooting while qedr is loaded with a VLAN interface present results in unregister_netdevice waiting for the usage count to become free. The fix is that rdma devices should be removed before unregistering the netdevice, to assure all references to ndev are decreased. Fixes: cee9fbd8e2e9 ("qede: Add qedr framework") Signed-off-by: Ariel Elior Signed-off-by: Michal Kalderon --- drivers/net/ethernet/qlogic/qede/qede_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index a01e7d6..f6655e2 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -1066,13 +1066,12 @@ static void __qede_remove(struct pci_dev *pdev, enum qede_remove_mode mode) DP_INFO(edev, "Starting qede_remove\n"); + qede_rdma_dev_remove(edev); unregister_netdev(ndev); cancel_delayed_work_sync(&edev->sp_task); qede_ptp_disable(edev); - qede_rdma_dev_remove(edev); - edev->ops->common->set_power_state(cdev, PCI_D0); pci_set_drvdata(pdev, NULL);