From patchwork Sat Apr 28 00:32:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 905999 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kuRhKY2V"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40XsHs48PMz9s06 for ; Sat, 28 Apr 2018 10:34:17 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933387AbeD1AeE (ORCPT ); Fri, 27 Apr 2018 20:34:04 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35988 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933277AbeD1Acz (ORCPT ); Fri, 27 Apr 2018 20:32:55 -0400 Received: by mail-pf0-f194.google.com with SMTP id g14so2617465pfh.3; Fri, 27 Apr 2018 17:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=55HFh1fmJ0RyaUhjV+dGAY2RM5zUbGJ7TgA3/F4wHoA=; b=kuRhKY2VIik6vIEv0lRphGYmXmyfqKAPHR7GcX7Q6cDmZxYRUeCIJAPNQ7xSc5OENl mphG34afhVhyhg+aXClRSPg2fbd00KKOf1dAuwzhgVSS9J7S4W7XIQ5MIY2f2kbQ3ULA r+TWdXrxB1BNKUObzU0PQWOgz35ST3ly8w3guq3ExepEJTZJd4stukN2gsB9aZ1ROmv4 lEKJaq+91tm2+Ij04xOLS0Tlekh89oGAfFhBKHgJegxduYR5zl3CLgehAsG3owIZFDCv dhlwWht0m2bM+fvpTMPPklWlJNlNy9avTRwKGzB5hDZ97ipOgOrLYsMg339CjesVnIeJ AaKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=55HFh1fmJ0RyaUhjV+dGAY2RM5zUbGJ7TgA3/F4wHoA=; b=DH/y6y7prYE7geBEKxbePewhqyb5JulbWNfn+9E2ZVgU+XzND9VH8499f7V2hlDG4n aN++pQqnJLYWHR0QOtbjeQl8Cts42UUOxyZJRi8F+wRyA9rHravyjguSIPnBTJaSwApM KxPHsFD9iRhIk2Qn6BnrRZIg+WEZ66XlQpm40k3qcMc5MuTqE24kMQoVmfKJiT1AnZxr J439N8H5nTYR1ghHAJW5x+aIzqqFfS8rGjdCY9PpFkgL0V6G9pgdoAOWLEk59SWwV22p eDm7pPjKtnvl+ahkmq+LoiejXFsHVxK7Ab0qy0kV0vxZSrg0F6U+Q03XFU2UhXIkHLeC 5CnA== X-Gm-Message-State: ALQs6tDcljKmNb3pZ3Az3oISn2syJu4cKOxblcMIuPnDXCLY2piQQz4L 7OozQdSbMdIRtWbbS+1AkoithvPe X-Google-Smtp-Source: AB8JxZoTVLAQLufKlwUQ8+BfVaffkZh1l/MxkTZg1H9qVkJ9U6ZRzw1Zk+iun/WPg/mLNqCAYMNNnQ== X-Received: by 2002:a17:902:4545:: with SMTP id m63-v6mr4224368pld.268.1524875574220; Fri, 27 Apr 2018 17:32:54 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id f184sm4694059pfb.52.2018.04.27.17.32.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 17:32:53 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , Russell King , linux-kernel@vger.kernel.org (open list), davem@davemloft.net, cphealy@gmail.com, nikita.yoush@cogentembedded.com, vivien.didelot@savoirfairelinux.com, Nisar.Sayed@microchip.com, UNGLinuxDriver@microchip.com Subject: [RFC net-next 5/5] net: phy: broadcom: Add support for PHY test modes Date: Fri, 27 Apr 2018 17:32:35 -0700 Message-Id: <20180428003237.1536-6-f.fainelli@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180428003237.1536-1-f.fainelli@gmail.com> References: <20180428003237.1536-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Re-use the generic PHY library test modes for 100BaseT2 and 1000BaseT and advertise support for those through the newly added ethtool knobs. Signed-off-by: Florian Fainelli --- drivers/net/phy/bcm-phy-lib.c | 15 +++++++++------ drivers/net/phy/bcm7xxx.c | 3 +++ 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/phy/bcm-phy-lib.c b/drivers/net/phy/bcm-phy-lib.c index e797e0863895..cb3081e523a5 100644 --- a/drivers/net/phy/bcm-phy-lib.c +++ b/drivers/net/phy/bcm-phy-lib.c @@ -334,6 +334,8 @@ int bcm_phy_get_sset_count(struct phy_device *phydev, int sset) { if (sset == ETH_SS_PHY_STATS) return ARRAY_SIZE(bcm_phy_hw_stats); + else if (sset == ETH_SS_PHY_TESTS) + return genphy_get_test_count(phydev); return -EOPNOTSUPP; } @@ -343,12 +345,13 @@ void bcm_phy_get_strings(struct phy_device *phydev, u32 stringset, u8 *data) { unsigned int i; - if (stringset != ETH_SS_PHY_STATS) - return; - - for (i = 0; i < ARRAY_SIZE(bcm_phy_hw_stats); i++) - strlcpy(data + i * ETH_GSTRING_LEN, - bcm_phy_hw_stats[i].string, ETH_GSTRING_LEN); + if (stringset == ETH_SS_PHY_STATS) { + for (i = 0; i < ARRAY_SIZE(bcm_phy_hw_stats); i++) + strlcpy(data + i * ETH_GSTRING_LEN, + bcm_phy_hw_stats[i].string, ETH_GSTRING_LEN); + } else if (stringset == ETH_SS_PHY_TESTS) { + genphy_get_test_strings(phydev, data); + } } EXPORT_SYMBOL_GPL(bcm_phy_get_strings); diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c index 1835af147eea..1efd287ed320 100644 --- a/drivers/net/phy/bcm7xxx.c +++ b/drivers/net/phy/bcm7xxx.c @@ -619,6 +619,9 @@ static int bcm7xxx_28nm_probe(struct phy_device *phydev) .get_sset_count = bcm_phy_get_sset_count, \ .get_strings = bcm_phy_get_strings, \ .get_stats = bcm7xxx_28nm_get_phy_stats, \ + .set_test = genphy_set_test, \ + .get_test = genphy_get_test, \ + .get_test_len = genphy_get_test_len, \ .probe = bcm7xxx_28nm_probe, \ }