Message ID | 20180425104307.8310-1-colin.king@canonical.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
Series | mkiss: remove redundant check for len > 0 | expand |
From: Colin King <colin.king@canonical.com> Date: Wed, 25 Apr 2018 11:43:07 +0100 > From: Colin Ian King <colin.king@canonical.com> > > The check for len > 0 is always true and hence is redundant as > this check is already being made to execute the code inside the > while-loop. Hence it is redundant and can be removed. > > Cleans up cppcheck warning: > drivers/net/hamradio/mkiss.c:220: (warning) Identical inner 'if' > condition is always true. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied.
diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index c180b480f8ef..13e4c1eff353 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -217,7 +217,7 @@ static int kiss_esc_crc(unsigned char *s, unsigned char *d, unsigned short crc, c = *s++; else if (len > 1) c = crc >> 8; - else if (len > 0) + else c = crc & 0xff; len--;