From patchwork Tue Apr 24 13:16:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 903476 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="I7Qdexe6"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40Vky06HBbz9s02 for ; Tue, 24 Apr 2018 23:41:28 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934475AbeDXNlZ (ORCPT ); Tue, 24 Apr 2018 09:41:25 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35916 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933793AbeDXNRD (ORCPT ); Tue, 24 Apr 2018 09:17:03 -0400 Received: by mail-wm0-f68.google.com with SMTP id n10so799581wmc.1; Tue, 24 Apr 2018 06:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=HdwE4rM3RDkdhJ30wuh00uhkkLmD1YDod7o5lvJzeu0=; b=I7Qdexe6lCwqjgjtHs/tc5hewZDmSD8xxdvEskBilBCCldUzMoq4bdOO7j+NC9ADJl q/54XFpc7oybL0z2B19oE4bCfjvrzUOz2voLEUFh309TAnKceEvuPcON+sZtvdNWrlXF IHt4uB05p5TK9RM0xmQBgWGEmisEU9EGKL16xn1TbvjRCmfHEGc37KvHXnPNF40Zqp9c sgBZJgp12czxiIbqwE8kTLNtGX/y4crjriWIunYl1HXoWZIypyuI5u3mpGprm9jMpMs2 YV2rSoHPVHQrwN9OEMY0E2zFSBI8IdamzsiZwR7PABzL4t8iLdSJbftXehWLgHfPjPmb aA7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HdwE4rM3RDkdhJ30wuh00uhkkLmD1YDod7o5lvJzeu0=; b=VIPVSXnNNxZvLCG0MXKMmmqjEuiyGgEU1QuWpdjUeSY8ZbcLA0AikCEJSSy6kZjLuo 7qqzN3ng2bVTXh3V4Mz0Qhf3rfU45WHwuKNrumabbIcLc3+9HQgEaClJssFcNV9WeunV 6QvtMlRFhi7CErchhf4HZeN5SH+Sr2Tc9OXM4gumqAp13wX+8qERmlyRWI+Q9/J2qk49 2ZS3oJBUSPjDE1WookoFoSsr2+CPAKxEVTr8uwvlIBeO2HFpAw8P4iiU3dpKN/oAZwmf 6BXRLP7PBZ1uyQvMQ0s1bh4rxyfzQEYkcf87i3dgoV3VYP+tJYL48l8ec8AomeAz5QWK iLeg== X-Gm-Message-State: ALQs6tBrM3L8s+md3uIpnBPtFivWjnBz/9iMsIAja0jCW2asyfNbBKN4 dznNyRK0x2mBwuKn3osMPROn/uPYIi0= X-Google-Smtp-Source: AIpwx4/N3KnW5lZITySZeMUzTjTaV3hJqZ2BdZKLPnLkeX8VqTFVShYqm/OjdozU3w71L6glgtI1Yg== X-Received: by 10.80.230.9 with SMTP id y9mr32643648edm.26.1524575821932; Tue, 24 Apr 2018 06:17:01 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:40e7:cd00:5113:f351:d61c:108c]) by smtp.gmail.com with ESMTPSA id e14sm8792148edk.29.2018.04.24.06.17.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Apr 2018 06:17:01 -0700 (PDT) From: Luc Van Oostenryck To: linux-kernel@vger.kernel.org Cc: Luc Van Oostenryck , "David S. Miller" , Kees Cook , Alexander Monakov , Allen Pais , netdev@vger.kernel.org Subject: [PATCH] net: pxa168: fix pxa168_eth_start_xmit()'s return type Date: Tue, 24 Apr 2018 15:16:58 +0200 Message-Id: <20180424131700.4104-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', which is a typedef for an enum type, but the implementation in this driver returns an 'int'. Fix this by returning 'netdev_tx_t' in this driver too. Signed-off-by: Luc Van Oostenryck --- drivers/net/ethernet/marvell/pxa168_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c index 3a9730612..d8745b503 100644 --- a/drivers/net/ethernet/marvell/pxa168_eth.c +++ b/drivers/net/ethernet/marvell/pxa168_eth.c @@ -1260,7 +1260,7 @@ static int pxa168_rx_poll(struct napi_struct *napi, int budget) return work_done; } -static int pxa168_eth_start_xmit(struct sk_buff *skb, struct net_device *dev) +static netdev_tx_t pxa168_eth_start_xmit(struct sk_buff *skb, struct net_device *dev) { struct pxa168_eth_private *pep = netdev_priv(dev); struct net_device_stats *stats = &dev->stats;