From patchwork Thu Mar 29 00:48:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 892528 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="ehLcodov"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40BR4B1161z9rxp for ; Thu, 29 Mar 2018 11:50:18 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbeC2AuL (ORCPT ); Wed, 28 Mar 2018 20:50:11 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:37396 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016AbeC2Atf (ORCPT ); Wed, 28 Mar 2018 20:49:35 -0400 Received: by mail-pf0-f194.google.com with SMTP id t16so2031768pfh.4 for ; Wed, 28 Mar 2018 17:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gcU9CKHiV8m6oHILUQSKJi4QROO/yZJG/ReAw3hO5JE=; b=ehLcodov3uOor748ed/3vcDt9l3KiTpY3UrCK6wLo9zZwXLrTZl3Y9RbwU/V8fQ3gm e+z6KhoM7q/k4sOtqv1afag9XDyURY86QkOOaAtaCaEalsu6xYQ5RmiFX9tscuYlID4t f+KkHbwhFRMGBXbN+ISt/xeWhtSQWVN6o2vcFGWgsK3z7JFIFa4/yJuFcYAPIXoSuQXa /I0CiAPWvZ8Dml2f/tKm3FC153ureGZ7mC9XvwxyniiHUHLsUBGyf20BPov42n44szeA Tbudi6YCQ0KlMRH2fSbnlLGB1EKIDPaLClz5mAB4wGJ40Gl95Qxmr9aIoC5/4ZV9nBkj oo8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gcU9CKHiV8m6oHILUQSKJi4QROO/yZJG/ReAw3hO5JE=; b=LGu3LF5hMZvaa59HDiRSa17eyQDQX48V+kWkGwR7myinKn7quwxU5bThB302CW1ENh tt5qFMtyhxj41vIxdtc+jFt+IVbV0l/pJc184dbC8ORfASCN10yQdCG889wqvaGphiVd WS2b4KjijFgGpcKhLNy9zY4XFwmRwcSje9sCdJ9vH/tcvx3T+ratXSpkhfX/xMHGHTip 0bRsgL33V3nqqzQnezutv/MkbZicLx+MC3X2gRlKjF8rlkNJw5GeXC5gWbbvlFsWbUam 4Nl1PwypQQpZkA7aZ4xqJJqzamvR8LTh6GEdveDEiJlAqYjPT9wu8vXb4HDlhSM1NfsM mqjg== X-Gm-Message-State: AElRT7GggbNISTyqNkkcP/BT/FG4e4f+T7V2xhZ3eLrOFn7h1r6rFfEp xlUCKlNGZQGrNflnk9XPXa9SEOn4 X-Google-Smtp-Source: AIpwx4/UD69E6/t1HuOP2x64TXD1T3fx6lzw3NtG5BivPM4WVTQ0vr0dCHCsCVx21EEH/Yi7jg8UKg== X-Received: by 2002:a17:902:59c9:: with SMTP id d9-v6mr6002896plj.251.1522284575447; Wed, 28 Mar 2018 17:49:35 -0700 (PDT) Received: from jkicinski-Precision-T1700.netronome.com ([75.53.12.129]) by smtp.gmail.com with ESMTPSA id k24sm9738979pfj.32.2018.03.28.17.49.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Mar 2018 17:49:34 -0700 (PDT) From: Jakub Kicinski To: alexei.starovoitov@gmail.com, daniel@iogearbox.net Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, Jan Gossens , Jakub Kicinski Subject: [PATCH bpf-next 09/14] bpf: add parenthesis around argument of BPF_LDST_BYTES() Date: Wed, 28 Mar 2018 17:48:33 -0700 Message-Id: <20180329004839.4506-10-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180329004839.4506-1-jakub.kicinski@netronome.com> References: <20180329004839.4506-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org BPF_LDST_BYTES() does not put it's argument in parenthesis when referencing it. This makes it impossible to pass pointers obtained by address-of operator (e.g. BPF_LDST_BYTES(&insn)). Add the parenthesis. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- include/linux/filter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/filter.h b/include/linux/filter.h index 109d05ccea9a..c2f167db8bd5 100644 --- a/include/linux/filter.h +++ b/include/linux/filter.h @@ -372,7 +372,7 @@ struct xdp_rxq_info; #define BPF_LDST_BYTES(insn) \ ({ \ - const int __size = bpf_size_to_bytes(BPF_SIZE(insn->code)); \ + const int __size = bpf_size_to_bytes(BPF_SIZE((insn)->code)); \ WARN_ON(__size < 0); \ __size; \ })