From patchwork Wed Mar 28 12:14:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudarsana Reddy Kalluru X-Patchwork-Id: 892111 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=cavium.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="WW4nqEu7"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40B6Jd5yQVz9s12 for ; Wed, 28 Mar 2018 23:14:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560AbeC1MOz (ORCPT ); Wed, 28 Mar 2018 08:14:55 -0400 Received: from mail-sn1nam02on0064.outbound.protection.outlook.com ([104.47.36.64]:9518 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751072AbeC1MOh (ORCPT ); Wed, 28 Mar 2018 08:14:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=m93DETHRcjZAFpVCbsv0Qupwy0bQhRvmGY+3x10u/oY=; b=WW4nqEu7QB3JehRPPlARCflh0apW3fgt9dzF9YMsiffX+edFFp+vokQxl1oQ9+JDIfDbNs+9ptohGc3xCv0HZXw3VvCXUaz5XOCnAI1k3to2gXYYuiujNgNZhAB3AJ/NzsJ7f+082xJ3N59157575aA5u4rp03rERWXT7/47NEg= Received: from CO2PR07CA0079.namprd07.prod.outlook.com (2603:10b6:100::47) by BYAPR07MB4214.namprd07.prod.outlook.com (2603:10b6:a02:be::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Wed, 28 Mar 2018 12:14:35 +0000 Received: from BN1AFFO11FD007.protection.gbl (2a01:111:f400:7c10::130) by CO2PR07CA0079.outlook.office365.com (2603:10b6:100::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.631.10 via Frontend Transport; Wed, 28 Mar 2018 12:14:34 +0000 Authentication-Results: spf=fail (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=cavium.com; Received-SPF: Fail (protection.outlook.com: domain of cavium.com does not designate 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD007.mail.protection.outlook.com (10.58.52.67) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.527.18 via Frontend Transport; Wed, 28 Mar 2018 12:14:34 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 28 Mar 2018 05:14:27 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id w2SCERXw007763; Wed, 28 Mar 2018 05:14:27 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id w2SCEQgY007762; Wed, 28 Mar 2018 05:14:26 -0700 From: Sudarsana Reddy Kalluru To: CC: , , Subject: [PATCH net-next v3 2/5] qed: Fix PTT entry leak in the selftest error flow. Date: Wed, 28 Mar 2018 05:14:20 -0700 Message-ID: <20180328121423.7718-3-sudarsana.kalluru@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20180328121423.7718-1-sudarsana.kalluru@cavium.com> References: <20180328121423.7718-1-sudarsana.kalluru@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(396003)(39380400002)(2980300002)(1110001)(1109001)(339900001)(199004)(189003)(446003)(1076002)(486005)(8676002)(106466001)(42186006)(59450400001)(76176011)(316002)(85426001)(486005)(2616005)(16586007)(54906003)(356003)(51416003)(86362001)(336012)(26005)(50466002)(72206003)(69596002)(81156014)(80596001)(50226002)(81166006)(305945005)(11346002)(87636003)(5660300001)(105606002)(186003)(47776003)(2906002)(6916009)(2351001)(8936002)(476003)(6666003)(4326008)(48376002)(36756003)(126002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4214; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD007; 1:67DBXvX3iN9RfN129Yj2uTy4FsOV0xLwrs2FPFRQN9UAndaiguxOT/BrZxG3HdnKQusOZpR/6P47QARbpk6NjqViZ0/gH70FqVA4Wzc0MpWqsfM46LSuRLieX8s7wpPo X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 428c3e5b-c5b0-4fda-8c9f-08d594a577e1 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:BYAPR07MB4214; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4214; 3:PBB3hHgqSbKfcjK0UHCegQ5MNWxmpBrgqoDciEqmoAcQR6S9IrbBYLpE+7wpRuOhLi70otgOzt8QQOk3ZHd+WLC/1LfKIe4Xf10hKtwBC+N0kK6zjHK4pqpYbhItwHzZtVcKxkZZi6cTrRNTUP8BxPjzQy9on6ZCi0DhNf3N1ukH5cVIwPiv4fy8+R/dtPQrG3p/eTN0P+ZqKSCMfaCrHbh4Db9zK8a3Baaf1DJSOo+t5Z2FrwYo33lBCMprUUv56uKDDkAZYHiSTreJc7OLyX5kDLZOPyN+KR0zRMRWO6x/h+KyVE92QgjwBMKvZpnEutHTo251UyOdeNNQU2IuCRwvIJ+41If5bsgT7GDFIJM=; 25:U0JoCq2Tk/aFoWnxZvMLoIJ9pxOlLHyAszfPsY6MKiNLYhwOLzQRkkm/816e7zc1zr7D+TOTsn/nKl8h1IVTetNbqFB2NtNNNuJ0Vo1wK/evk8KVtuIqncqROrC/EKzzK4Yl8Cpz0C1TE352yOVw39i14Z+EI6RUox+gQI3xleez02zawDRDaUv5IhdQq7uZ8rsIU2DKwW6Jj8k9HOWBmuIaiavLDpaeE3UnNnpIoew34+/DWvivoOHgCg9tlNZm1tOozjtcyW1VVe5grsZJFdzhQ3sRAwTvBvEh4kmGGydLNgAZ13G6tpOk1nao+t5+vWYqNOGZ9w4o1QAT/Re6ow== X-MS-TrafficTypeDiagnostic: BYAPR07MB4214: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4214; 31:lE6JEnoiDZ8Lf1vopKaXyY9DoGtStlMK89mhSFDXXiAGVPg/hCYXMCkeaNYCfbAN3EhZ7adzB8I+P1HHPZuRVFoQ1+DeLc2Ug7gWX50qd5IFk0Z8rem+rxosj1IjqEUcjfJoTv8C/XlGRsviYTC3tZ1ylD927huJDY3W1DY3wXxRgiwY+NurAuehYvPcV7AIFBujFqCg1IYVqhjvc6LPiUqMNEx1WByVrZgJDudRKlg=; 20:RNgfuu7XZbUVXqJO4amsUX8zK5Gd0tw4iGUI0GRWDAygw7+Cgj/0t4IOvE0F3WaR/ceDbkZvlYMTNHFBW7CYuBryFQeFCFQE2IRHzyv2qex0nbN3IlxtuDRD1fq+yTZNYxBPJrMUfyJnknPOVkuoV2ZDaZv9N8EOX51yFcnzBwVNbst1r5IQ/bhiLr9weykrdkBYTKEx3LWfadCW6rwE3ycobQhnKGiKH+cgM0e68Eks7v3GQR1ONT9cHfpXZQO2Ws1R/fv/fWBwPRIqaldgAqKWN48Ab96z2HIZF1mohvNQS+KzmAGJBdhZEANNAcBbw95kNXb+jTIW1hAQoFuyRWaB8Wngu6qiQno59xEToJlWHNP/YqZo2W5yUcz7QYmTNvl2A2s9KlNLFTH1yRv5SSrjZXuUvNYtACc8big+xkflGkmnnru5EtKkKQVKiv9hIN2s8gkpd1H/p4VjixG2jtWpWKs4+wKoPfzKWSiGr8o0Ke1mnBCoCol2s84GTDQm X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(93001095)(3002001)(10201501046)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:BYAPR07MB4214; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4214; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4214; 4:7hhMBLNpdExTY7AM13uBmZRhKOSHOn44A3U3kHeJpijPNH17JIe81CkN19++YQq72Qgh9rr0wmaaEseCzXB2Yu2Q4WBK+ymdEUThy7t8W5vfJTQGSVYLUX7rqTP96dNAakgehEZNwi6AI63Iv5eQgT2da6oCefCIF+UBkXNlPWjVImgndKI4L22LBx3VCA7qkXoIntS/kO0aRKAKFkb1M8JnS/knkODpKEh/0IxzOYJcyomxaqTSIYnnh3t2JjY+ODH8mO7sxvpnksr0+QS5tQ== X-Forefront-PRVS: 06259BA5A2 X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4214; 23:bEjVkeDvZRiDzhzVk9/ZDNcHIS9dgEStQ/9P+VuS6MFvFIULIBdmHzG20o3eIYZCAH1jpXzwsaOQ9i/wRWE5fH4U4sGu0maCjP5srpfHoAT8IbQi3jmeDxHPlw0tSRWzxtuMaUTPP9ABM+K7jvr6LHdxCFTn+33LoMC9suhWkWyl+S/nTHIk60VaqwJB1Y91NQE6pYnEp4Si2/d7xWTSd6hguOLzXfR0uBzzBbwubYEx5Jb4NtSqDT+3gXbptpwNoP6LO+qUlgqtL5S+v7Jtt8TWZz3jmKVwvmqEHd7VVWnS6P37ExwM+O4XAL01Z60bD2U6e/kYTGqk9MxTDKVWikXcSHlN28+SFhGe+vDlNYg2CH/uPatLOyYJdXdlMH2ZiYDeYyHJ5EeMdaelCrxKqfP4KUXZ61Gehs+ekAnCGAB9y9eFSqZvnsUZFF8VyuevQdk9W8d8bvoxm5CIicH3z4V7TSkELPZGwOs2wbgbyBDCxjjhvSTar7efhsDDXOXjONaiRnx6MSTWEJgixpP41FXYDTE88PlASO8spEH55dCVXYqYoheJDAPnJhI/XuMf6OJL81uFvpimUmOMs+Pz148Xkl8cr+9Xp41gNIXL3ynEmYg39U93z4AygAfBcntYiRaY2MxO+kYvHSAMiv7zzj3pOgVHYIDOEGjPI9PUWHgk57UlJWL94g0BMU7BMqw7PMCH0Fw0x9nhTwBgihHRw6rB92L/2Zah9pnhWifHPJS7wuV/C3/KbcKcS1iPS3PDd6UD74SrRCbH0O7UPccKp7lVE4mi8ou+N+kGr4y7Pzl2R6XD8VW+kVQ3nAlHDgaxjwC5Maa0qlaQX0QZZo54LlGwIWuhFCzIQ7HECIGb8KoPqr8ie5+QiD1wJF8ae2olIt9eUHpzIBBnRdFqICcruiZFd65KdvPtcYnJUvZLjyhE+tJ8GSp8oj0CPmaBmRtsmYyRM12ANQH+Q8K88VK9vwFzobhfhOUY1p5hfc4SqkQn1xHGOO5gEElwHEv6LjUCWbphaJzVCgU0uvUP6tNHRv5Z0E9uvmD286mV8gN5T074fhFW32rFXcbf0cxX7X2YcMt3k44gJstyOQ3EzlvVTal+fiR7oWsk7Hl0e2Y0uLjtSSTsTLOegWTlR1B6N+IMk7+JroVmon2wEJ1Ay25BFDMKJMam6WLTCHBBwF+3K+UV5Diy8WcqJXUbJBNEcWn3DcHyResPfEN7tyqfXFCJ6Q== X-Microsoft-Antispam-Message-Info: NsnOs1P6kvyeQKz0WVvpOsBIT7C/TkbgmIHq5EXwDkKb01mqsPQS4n3m5A2GGLCkpXXu6twencH/gb882HrCD8i873F8UYeMJoMGEefmbo2BD23Gjb+P5u/dxuPZ3FWLeciWho6XPjf5aclVIcpmgRCNrf9PCGDpeLFGceoCEIjZZQISRoKs8CsRM0fYFU0O X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4214; 6:EMvcbjfHR4m1niWr4IZcdmU/U/v2LZNsh+ut0zuLmtb4y80vLUrToSgf0dgt0qV6GtYE/93AUzp6R3ZsK3G/ZgWo79/FjQbI9yF5LT+6Abgp9Jt+b9ja1kmuGxDcxPfTiFrzsDsuGnSoGy6gUvHeIFuvC6RlmE+5WLrVstHu8f9jpDw/Kh0RDCgjx/B70NFAjuCwIlFr5qN7mcJDoouTG/CfYSnqq7APt5dgGdsL4sCQ+MAxm6QCNupxRgFCuPl0Dh17xNDelru6agKYJOprbMPHOeipz0DPrMBiDFS1/h6BEwmGuP5hWjXQrUEg8zcSUcEWsfgWYoY9+K0mj44i1mj+szvZHrt7raFQ0yJ/caYf864GgG+Ai01X0khSRgZaM2FMUm991lbNsXL5W2NWZgoFuqNksArl/kh+IdGSG0g2YXZdJXKHsXGzvdkrEhLn+zghr/dQ7QzDkIF0dhV/Ew==; 5:47PmBLtv5/l9eC++r2Ij4Q28MvI22HAlMxjhqyKSFwwSErv5w6sZ4gHnmD59U96ZSChTh7UUTvbJxkbhw7QMnyc2Gkez0yTq3DszV+F3z5C8psRaKtq4klee6qisM1UnJmXjDdUa0aCRKRHStlHLM9RU7rBxu0vZz/kDeGZzHrM=; 24:2O+NqHq/IfmvLRsiG7IOvvugPN9YAfc/Lv2jSFr9DtTQVcWl6ZbTpA9uQfxrLJhZHwHat2sx2ZfyKhSS11tHV5KMcPMTxop9UDPzPjQ7/h4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4214; 7:nqMfcHdsS1kzN/qdWIO9i73Uo4+kN2dhmjQ2jnUUSV6ORSTqGtBEoRGbkiIsvoxx8xH3fTI/jQ54YeDCTZZYx/JYLo2IntL0OE8R2dXett9LUsh26Aa97EFt7TuUCl9q4RkmTkmJAtunbSh6+Mt1aag7N3qD2YJaheK+Wbz3RK++PHWj2UsQqBcRj1u5tPjve5uGieSVjzoFSUgk3skI3ukkn9wUHGRCNW/ZOM979gTitXJkLuX+siXxbiIyjidr X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2018 12:14:34.1146 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 428c3e5b-c5b0-4fda-8c9f-08d594a577e1 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4214 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_selftest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_selftest.c b/drivers/net/ethernet/qlogic/qed/qed_selftest.c index b88082f..cf1d447 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_selftest.c +++ b/drivers/net/ethernet/qlogic/qed/qed_selftest.c @@ -128,7 +128,8 @@ int qed_selftest_nvram(struct qed_dev *cdev) rc = qed_mcp_bist_nvm_get_num_images(p_hwfn, p_ptt, &num_images); if (rc || !num_images) { DP_ERR(p_hwfn, "Failed getting number of images\n"); - return -EINVAL; + rc = -EINVAL; + goto err0; } /* Iterate over images and validate CRC */