| Message ID | 20180325063856.31709-1-leon@kernel.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Ahern |
| Headers | show |
| Series | [iproute2-next] rdma: Move RDMA UAPI header file to be under RDMA responsibility | expand |
> Subject: [PATCH iproute2-next] rdma: Move RDMA UAPI header file to be > under RDMA responsibility > > From: Leon Romanovsky <leonro@mellanox.com> > > In iproute2 package, the updates of UAPIs files are performed > after the needed feature lands in kernel's net-next tree. > > Such development flow created delays to the rdma tool developers, > who uses rdma-next tree as a basis for their work. > > Move RDMA UAPI file to be under rdma/ folder, so whole responsibility > of syncing this file will be on them. > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> Reviewed-by: Steve Wise <swise@opengridcomputing.com>
On 3/25/18 12:38 AM, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@mellanox.com> > > In iproute2 package, the updates of UAPIs files are performed > after the needed feature lands in kernel's net-next tree. > > Such development flow created delays to the rdma tool developers, > who uses rdma-next tree as a basis for their work. > > Move RDMA UAPI file to be under rdma/ folder, so whole responsibility > of syncing this file will be on them. > > Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > --- > rdma/Makefile | 1 + > {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0 > 2 files changed, 1 insertion(+) > rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%) applied to iproute2-next
On 3/26/2018 9:03 AM, David Ahern wrote: > On 3/25/18 12:38 AM, Leon Romanovsky wrote: >> From: Leon Romanovsky <leonro@mellanox.com> >> >> In iproute2 package, the updates of UAPIs files are performed >> after the needed feature lands in kernel's net-next tree. >> >> Such development flow created delays to the rdma tool developers, >> who uses rdma-next tree as a basis for their work. >> >> Move RDMA UAPI file to be under rdma/ folder, so whole responsibility >> of syncing this file will be on them. >> >> Signed-off-by: Leon Romanovsky <leonro@mellanox.com> >> --- >> rdma/Makefile | 1 + >> {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0 >> 2 files changed, 1 insertion(+) >> rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%) > applied to iproute2-next > Hey Leon, so how do I change rdma/include/uapi/rdma_netlink.h now for my series [1]? Do I just make the changes? Or is there some other process? [1] https://www.spinics.net/lists/linux-rdma/msg61419.html Steve.
On Mon, Mar 26, 2018 at 09:23:46AM -0500, Steve Wise wrote: > > > On 3/26/2018 9:03 AM, David Ahern wrote: > > On 3/25/18 12:38 AM, Leon Romanovsky wrote: > >> From: Leon Romanovsky <leonro@mellanox.com> > >> > >> In iproute2 package, the updates of UAPIs files are performed > >> after the needed feature lands in kernel's net-next tree. > >> > >> Such development flow created delays to the rdma tool developers, > >> who uses rdma-next tree as a basis for their work. > >> > >> Move RDMA UAPI file to be under rdma/ folder, so whole responsibility > >> of syncing this file will be on them. > >> > >> Signed-off-by: Leon Romanovsky <leonro@mellanox.com> > >> --- > >> rdma/Makefile | 1 + > >> {include => rdma/include}/uapi/rdma/rdma_netlink.h | 0 > >> 2 files changed, 1 insertion(+) > >> rename {include => rdma/include}/uapi/rdma/rdma_netlink.h (100%) > > applied to iproute2-next > > > > Hey Leon, so how do I change rdma/include/uapi/rdma_netlink.h now for my > series [1]? Do I just make the changes? Or is there some other process? I don't think that we need "process" yet, simply copy from kernel. > > [1] https://www.spinics.net/lists/linux-rdma/msg61419.html > > Steve.
diff --git a/rdma/Makefile b/rdma/Makefile index 360f09b2..819fcbe3 100644 --- a/rdma/Makefile +++ b/rdma/Makefile @@ -4,6 +4,7 @@ include ../config.mk TARGETS := ifeq ($(HAVE_MNL),y) +CFLAGS += -I./include/uapi/ RDMA_OBJ = rdma.o utils.o dev.o link.o res.o diff --git a/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h similarity index 100% rename from include/uapi/rdma/rdma_netlink.h rename to rdma/include/uapi/rdma/rdma_netlink.h