| Message ID | 20180314203209.26532-1-vinicius.gomes@intel.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] skbuff: Fix not waking applications when errors are enqueued | expand |
From: Vinicius Costa Gomes <vinicius.gomes@intel.com> Date: Wed, 14 Mar 2018 13:32:09 -0700 > When errors are enqueued to the error queue via sock_queue_err_skb() > function, it is possible that the waiting application is not notified. > > Calling 'sk->sk_data_ready()' would not notify applications that > selected only POLLERR events in poll() (for example). > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Reported-by: Randy E. Witt <randy.e.witt@intel.com> > Reviewed-by: Eric Dumazet <edumazet@google.com> > Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> Applied and queued up for -stable, thank you. Since this is going into 'net', it doesn't need to be in your net-next submission as 'net' changes will (eventually) propagate into net-next. Please fix that up, thank you.
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index baf990528943..1ea4be79c0a7 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -4179,7 +4179,7 @@ int sock_queue_err_skb(struct sock *sk, struct sk_buff *skb) skb_queue_tail(&sk->sk_error_queue, skb); if (!sock_flag(sk, SOCK_DEAD)) - sk->sk_data_ready(sk); + sk->sk_error_report(sk); return 0; } EXPORT_SYMBOL(sock_queue_err_skb);
When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting application is not notified. Calling 'sk->sk_data_ready()' would not notify applications that selected only POLLERR events in poll() (for example). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Randy E. Witt <randy.e.witt@intel.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)