| Message ID | 20180312231052.13961-3-vinicius.gomes@intel.com |
|---|---|
| State | RFC, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | skbuff: Fix applications not being woken for errors | expand |
On 03/12/2018 04:10 PM, Vinicius Costa Gomes wrote: > When errors are enqueued to the error queue via sock_queue_err_skb() > function, it is possible that the correct application is not notified. Your patch makes sense, thanks.
Hi Eric Dumazet <eric.dumazet@gmail.com> writes: > On 03/12/2018 04:10 PM, Vinicius Costa Gomes wrote: >> When errors are enqueued to the error queue via sock_queue_err_skb() >> function, it is possible that the correct application is not notified. > > Your patch makes sense, thanks. Cool. Will send a non-RFC version then. Would the changes to txtimestamp selftest be helpful? Cheers, -- Vinicius
On 03/13/2018 10:20 AM, Vinicius Costa Gomes wrote: > Hi > Cool. Will send a non-RFC version then. > > Would the changes to txtimestamp selftest be helpful? Yes, since it could have spotted the bug earlier. Thanks.
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 715c13495ba6..6def3534f509 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -4181,7 +4181,7 @@ int sock_queue_err_skb(struct sock *sk, struct sk_buff *skb) skb_queue_tail(&sk->sk_error_queue, skb); if (!sock_flag(sk, SOCK_DEAD)) - sk->sk_data_ready(sk); + sk->sk_error_report(sk); return 0; } EXPORT_SYMBOL(sock_queue_err_skb);
When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the correct application is not notified. Reported-by: Randy E. Witt <randy.e.witt@intel.com> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)