From patchwork Tue Jan 16 21:38:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 861896 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="v+pFtT9H"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zLkBL1WFhz9s82 for ; Wed, 17 Jan 2018 08:39:06 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751428AbeAPVjD (ORCPT ); Tue, 16 Jan 2018 16:39:03 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:43324 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbeAPVjB (ORCPT ); Tue, 16 Jan 2018 16:39:01 -0500 Received: by mail-pf0-f196.google.com with SMTP id y26so2808007pfi.10 for ; Tue, 16 Jan 2018 13:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bvYCQVlb3SBF2QAlaMqhq8VLFo4BQDhJA4LLYTSyzeE=; b=v+pFtT9HNS/ddNs0To/oT+5IBIVDi95AfdggYakNtnO4BByM8UdrrMUhLijZ+4pMsm Qh2XeNutHS5dSE2QpAYEhtJOkgUrp8B1FEDxdGbJigEL+9GkxpdZU6YTnqZt8udV7JpE 2KRVuz9G3yGQkboJHLcR2IhfXcXc5eQYQYF5OrhADlQQUnjI94JmDYfWXbBd4wTd/nFd NVmPbaSXEzBrje7FcLBFINjsipx05bgxYvAJfMEq2ClQVZNeW6tdRZ/9HUU92sOR9R7I IeXaVM11uwkXM8e7CCxZetg62cazPmNwLECKqEn0tDqR8DOizo8WuX5eGrRB03IYJj9k IR+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bvYCQVlb3SBF2QAlaMqhq8VLFo4BQDhJA4LLYTSyzeE=; b=GwjR5ziCr7494O3yM0DROLM82McPJop59vkUR7dbNXAq5ZFmJI563nYHQxTxX4Ac09 NeLcdK1uJ+nplHlE1js6tgITBwE+heloNY+XuGgyP5c5xd4ALWHVBtdfhD/nZM4D2i7Y 2g0jbOHIJsO/BSMLq4I01wFuunmOa4MH/G1O3hCG4k5wMOV7N7/f24Frqc3xhb88JbSB MGhEeVT66ULF98RUO6aTaNjQQ6Gcp35AP8a2c5DKVn+Kr4jO70A+EWwofsl3bCEvAAw5 SuiCsjDryiGJ/GvchF5xLPsEUzb8NZfzjqZ7jCAfDCeVayw3dQcDxJOCaYFO4rg/iwD2 VgpA== X-Gm-Message-State: AKGB3mISX67ouRztxFhuQ9kPJzuRL3+79hy31FSa6SshthUcwleD5mBi PkHVh/MTzskmXtrFGv5OP3P9kw== X-Google-Smtp-Source: ACJfBot1H1jpldZVnHSZyRkIlOnJiy5m/t7H5j9qE2syoBmbnkcqszXZZh/3luCO74yHIel1RVF2wA== X-Received: by 10.99.43.137 with SMTP id r131mr31474274pgr.205.1516138740667; Tue, 16 Jan 2018 13:39:00 -0800 (PST) Received: from jkicinski-Precision-T1700.netronome.com ([75.53.12.129]) by smtp.gmail.com with ESMTPSA id y7sm5073736pfy.96.2018.01.16.13.38.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Jan 2018 13:39:00 -0800 (PST) From: Jakub Kicinski To: davem@davemloft.net, daniel@iogearbox.net, alexei.starovoitov@gmail.com, netdev@vger.kernel.org Cc: dsahern@gmail.com, oss-drivers@netronome.com, jiri@resnulli.us, john.fastabend@gmail.com, jhs@mojatatu.com, gerlitz.or@gmail.com, aring@mojatatu.com, xiyou.wangcong@gmail.com, Quentin Monnet Subject: [PATCH bpf-next v3 03/11] net: sched: cls_matchall: propagate extack support for filter offload Date: Tue, 16 Jan 2018 13:38:31 -0800 Message-Id: <20180116213839.24537-4-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180116213839.24537-1-jakub.kicinski@netronome.com> References: <20180116213839.24537-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Quentin Monnet Propagate the extack pointer from the `->change()` classifier operation to the function used for filter replacement in cls_matchall. This makes it possible to use netlink extack messages in the future at replacement time for this filter, although it is not used at this point. Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicinski --- net/sched/cls_matchall.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c index dc3c57116bbd..16752abcb76b 100644 --- a/net/sched/cls_matchall.c +++ b/net/sched/cls_matchall.c @@ -85,7 +85,8 @@ static void mall_destroy_hw_filter(struct tcf_proto *tp, static int mall_replace_hw_filter(struct tcf_proto *tp, struct cls_mall_head *head, - unsigned long cookie) + unsigned long cookie, + struct netlink_ext_ack *extack) { struct tc_cls_matchall_offload cls_mall = {}; struct tcf_block *block = tp->chain->block; @@ -202,7 +203,8 @@ static int mall_change(struct net *net, struct sk_buff *in_skb, goto err_set_parms; if (!tc_skip_hw(new->flags)) { - err = mall_replace_hw_filter(tp, new, (unsigned long) new); + err = mall_replace_hw_filter(tp, new, (unsigned long)new, + extack); if (err) goto err_replace_hw_filter; }