From patchwork Sun Jan 7 10:45:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 856519 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="PMLJm3A5"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zDw8R139Lz9ryr for ; Sun, 7 Jan 2018 21:47:19 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753497AbeAGKrQ (ORCPT ); Sun, 7 Jan 2018 05:47:16 -0500 Received: from mail-eopbgr00048.outbound.protection.outlook.com ([40.107.0.48]:42941 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753061AbeAGKrG (ORCPT ); Sun, 7 Jan 2018 05:47:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XgoYO3Re+9M+r7lINd6RPzDSP7CT8Ca8+JA/wXN2MrY=; b=PMLJm3A5VqpNPjKPNwu3q0SRhIveLc/ue+eMRS1Z+6wMDrH46GgoXK71fR40Umc30s/tqwJw6zqstRce9q4fCddMjFb1nV8doO1w24MZxzt5IoGGteOHyvOkGE+iAnb5S+ZOPUi+haaIlC5WW57VhS8AaSY936qDwzX+1yCV+U0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; Received: from splinter.mtl.com (79.177.48.236) by HE1PR0501MB2012.eurprd05.prod.outlook.com (2603:10a6:3:35::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Sun, 7 Jan 2018 10:46:59 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, dsahern@gmail.com, roopa@cumulusnetworks.com, nicolas.dichtel@6wind.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org, mlxsw@mellanox.com, Ido Schimmel Subject: [PATCH net-next 11/18] ipv6: Add explicit flush indication to routes Date: Sun, 7 Jan 2018 12:45:11 +0200 Message-Id: <20180107104518.31693-12-idosch@mellanox.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180107104518.31693-1-idosch@mellanox.com> References: <20180107104518.31693-1-idosch@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [79.177.48.236] X-ClientProxiedBy: VI1PR0701CA0039.eurprd07.prod.outlook.com (2603:10a6:800:90::25) To HE1PR0501MB2012.eurprd05.prod.outlook.com (2603:10a6:3:35::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1726bb5b-f265-48c3-57ed-08d555bbfc42 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:HE1PR0501MB2012; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2012; 3:0MLRQ0R9ZieurVPJqUC+4pSViBrqb0JvaZeoCoOIZE2BumFaUvgLQLoT3u9iY8t4dYSwd8uaMHm3ZpZBernshZnVNJSBlL+huB6R93qHI5OeA+WDeY21YssW/BBZOT/CLBxuDciPu07Xuj0X6t1AYlHhuBPJkTnJO82llucc39/BhJW4ZtdD/P4a4X8GZSTq3Yqqmtd24HeXg5Cx4n5ptrsh9qlnwGUKS1YvPnE8hqgn1soothzNO8rj+YfB7uLC; 25:WfSpfo9SnKdRTcTsm/MKlOAk11WYL2JFf9eqiaXO8Yw2ikizxpVZ0G6OshgMvBDyM05svQ+NLzE/NTLrrk9sHLVAzHY6UdWjXQuli4jm8jH9BU87vzMahQqJ19AzOqe+Q6UvBaAU0/1k5UPjXhkbtgAArmqZwCvp6/wI0M4BpWyJiqIB+PADE98mPLYySXQ24CHfyOelohW7DygzwuYLeZhTVut5Ed/WxVN/3SvADsMtQjQLEQwa2Lv+2i84my3RggJAhmEbKzQP8AHTRfU+1yLgzQmIsKwf27KBUn3n1n7rBzOOP8S9viBjC8Ing467PRypOdca0plbXaEJIE90kg==; 31:tZ5Eb66VSw6ywaXXgFrC44R7BOcuaEbZQswVQmmFhqZ1Y3uNhXy5l6UOR42Fq26dcnpblwWzTZSZy6HcbgQ2dezr8IT1DuYf4dPZi+0IS09F90bPt9upODH5VV8Au0PUQKZv895LFyXdwT6JKMq5RYz9+A4NHN8erl6FzgdKnzRc6rUtNpqgXQW2ZZIxR602tfdXk+I2meHCWikK6z5X6UZo4fiF2JL9SOVmkGK53aE= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2012: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2012; 20:7DpX88lNVX3xeO9NN4g8tCDpmaUs99lnrEYWG/pj8VrzLy3JKXnrSlqeZnGN3fUPSM5vFFZzifclupbfKBRYIb2BpuuMcD575SHv6QSfH01hrdHEGGjRcJZJUJ0Zg70q716HRkH+3ibRHerYuZyVOz8vmVrwQV5DCaRIqqoVh+cmCi2eAXLPx0Il589FCLdSh2bS011xtpWM9KGSzFHjbK2RuYUL3xYXpeXB/+YxlQ3Wv2kFcn+Zy+S9XnHlq/yXB1rK4CmB37bTjEwGDU3yl/ISxEkUSCM52KA7nnkHMIl5EP/3m1SBQQ+m8ueobA0fgD9Sh67YNEDw3kgLxFaYMKe3LdQqSoww//PvYZQl5M5Qg53BhOSQjFCqFgezYTHTlaksnZ7LEykYbLUEUhFBsqeXRD6ox9ikt0FCO/t4c1/vQub/HkecTbxW1ZFWkT7xlqRy/b8LG4zdphSi8Q4aAZ7mqEeqjhlKr9C2/KGkOkCR0zahapBZ4jkL9zMtoF+P; 4:596a3Fbx6qohIP1RhaNrxPnc37XRTzjQUFZY+ByERuh4AAGnzocXhyrkk1s6jLGFScL/S85cJsPfC5o2J7ZUL3mx/TltMJ824rpO/YylVrl5FNDOH4aQjFKRWDbxo0eQu+G9zSpUS2hoBBoIUQ/jpCs1k3s2SZjx4UCyw3/o9CSlcLjDAT9nlITSPBwgJtiSaMKBvGHrZdZ4vGCNdSPVzj6WBi6YuTF3eNlrXVWYZlMazkqJJN0KK+AxRcViw0T+gpW7whgKipxoUXd7DUR2+w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231023)(944501075)(6055026)(6041268)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:HE1PR0501MB2012; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:HE1PR0501MB2012; X-Forefront-PRVS: 0545EFAC9A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(39380400002)(376002)(39860400002)(189003)(199004)(107886003)(106356001)(59450400001)(76176011)(51416003)(50466002)(86362001)(16586007)(4326008)(8936002)(68736007)(105586002)(81166006)(1076002)(81156014)(2361001)(47776003)(6486002)(6506007)(50226002)(386003)(6512007)(66066001)(16526018)(8676002)(2351001)(5660300001)(53936002)(7736002)(36756003)(2950100002)(6916009)(305945005)(97736004)(478600001)(6666003)(2906002)(6116002)(52116002)(48376002)(25786009)(3846002)(316002)(53416004); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2012; H:splinter.mtl.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2012; 23:ksG0dIqHGxqhq02xWOxs7KCn3Q2CfmaFkWinzQuNJY75MHR+LvubpuqG345XhygZe4peG4CidO5r1kOH1/Wso02Oi1A0V2obyQVMJ3KYvEdAdE9AvaIX1hWOi+OM9eEgz+mFuYFqXibn+2dMhjXKT3yXFDj+ujM9n6SczYikKc4MI7Zc8iPs3SN1mPqqL38ONB3Z+hNZrEtN8tcpGYCWeauuJcK3hdYtUxwIVsaE7LGF1fj+Gih4HlbfOOnA2YC4hxAk3SOyWRx0lditeLVdpXSuYYiRtwOlSnLYh7FaT092Vkf6gwRADQ7JcBUNrHuZnRrlmh31zqp61hn2G1xKLl3K+oZekx24CT1Rh5TLcDvrWo0dBKGkMKeDpOC+dnYczLwryGD2Cujws3klE+zEQnyp11YXHUZ5iOvk3OaT3Kz5tmK2scaxcCcW9C6Y1ly193V3r/75rNr3rafJMILt0fQRP1mr5jPfOufNy8cd+BkrZmTjwU7zuGXZa0othvNtrElUJzZq4OlnN+nb72nzGMT+TYuZ+NnfRuHovr6DL8n/fyRS/hW3CfErcwnVPoJ5wRLQC3HZG5/WMT5p8tnPNufWJ7cUuFTs3bSBF3THm8F3p1PYd5NevlU++oMXi7Y/uiBUyRBU5/RzelLEWjY5vebjWW/848ewm7N3Yd8nuQSuhi8l+aah+ng3Fka69qsRDu8eZgcAxlkQ2+L6HtaS2VLcZ60+ye2kxiG40f6EOK6jdg36wEjg2eH5eZXTC5gxHGbG8G8KH87RkYOlKDNgTUAC3axmRQrI2+Df2wi/A32ON5Yvpyfw5AXcpBSPbeLvmzjcPGpVQQh3HSebYWJxogxYy8HpTBLDf4bmNi14PWOYbGhnjuXTH4OWHUALhFbuw25mnAdD/GbtcaKOAkuUYqHCkVxFmwsjh5JeBJUCnD+8jhbwwO+4yhc3WZRZzude0trAm9uckL6ABGfwIdkUrrq1vFTA1wAOvbZNbG7oeB/53nau48GorLlSrOkVF+YDXPpPNtetQ2tBck7ialYe+tq1rYrKhKrJ85dlMFXqzsKknv9S8huJUj3EzcqboMlVYULM0D+JWuIwe9icbOTyNs5oqtusvBXHr6XJJsqfCGVF1iCLCBFqpeB78cTlzOjPa0+4H5i2bETZaOlgJEEzZbS5hOYh62bhfZpprVmWYDYRrYKB4+BldHjmyXJ8X+f6 X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2012; 6:eHhHypkUAlDRkAlFVrGg4FY0hXGV34uqIh0/e3RR3G56Jo6HuXYvn4QTwQQnM7zXBCffAltNX2aIHsiAEkFTmtKNUtiZyFniXnEomo7AYYAdxJ96TKk2sgi8QOWAzmbldMMp32qGtenZHdQY1dPjYLu/hfj66JZ0dTg+AWF9yktgnlpUO/btyTv/k4foESGRdqrKTI3nBH8oImCIHYcVE9fhwdXCxOZU1wEoqei6rgvddEUsW2NsrfZhgL7PBG6L7wYStVdEQiKr87/sqV/2rxV64/PeXWLEFbHPn7UiE+/KTbE42cmltX/TG1DCxAPK8/8oysuofRfTCJxgpTgWStrc17MnZgNkslJHPjfLsio=; 5:leZ1VSHV4s/1XshujyXOy6n4CelmMXujrB5LYbUHemXrsou6kntdcSITDB39qwpyxLSXWWs7mOFOaIVZunzjxDjob9d62906wPHUl2h5b2uRd572Rj3BwPfI5+q1wA/TQpYLeR78sTJMzw8sQu0giBBfZt6o4jlv3QyobL1PVmY=; 24:5FJ2K+olKqwN3v9AVrywTJMiVSbyXc+bLzDTRGXLLTF9ICFPEft6bytg7hdQHlrd8RegNsDYPHu/1xwjQyQZCQHIrr6Qr0GrR4lmAoUkLhI=; 7:Cj6etRREVhED0PsDnj2BRVFYHa/tOTTPze3U2aHR+8R8QP/NXtYw9lJ+bwOBgZGFOmqQIEoIJOEnuveneF+YGBXahN5t3zPZh6foR6NZ4nyCous2o60u596+XrZHR33Guxv6rRLKAJlQp2K8nfoZEd/nLYvElOuwqNxpprbfiNN29F5v3yzickhf6N8M9MaeSNszHeSHBMw7eyF/XMiEEfBVcMYu0IGclZyjvyNiopKFiMvx5ASMIzQ/FtPXrWJp SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2018 10:46:59.9900 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1726bb5b-f265-48c3-57ed-08d555bbfc42 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2012 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When routes that are a part of a multipath route are evaluated by fib6_ifdown() in response to NETDEV_DOWN and NETDEV_UNREGISTER events the state of their sibling routes is not considered. This will change in subsequent patches in order to align IPv6 with IPv4's behavior. For example, when the last sibling in a multipath route becomes dead, the entire multipath route needs to be removed. To prevent the tree walker from re-evaluating all the sibling routes each time, we can simply evaluate them once - when the first sibling is traversed. If we determine the entire multipath route needs to be removed, then the 'should_flush' bit is set in all the siblings, which will cause the walker to flush them when it traverses them. Signed-off-by: Ido Schimmel Acked-by: David Ahern --- include/net/ip6_fib.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h index 44d96a91e745..affea1aa6ae4 100644 --- a/include/net/ip6_fib.h +++ b/include/net/ip6_fib.h @@ -173,7 +173,8 @@ struct rt6_info { unsigned short rt6i_nfheader_len; u8 rt6i_protocol; u8 exception_bucket_flushed:1, - unused:7; + should_flush:1, + unused:6; }; #define for_each_fib6_node_rt_rcu(fn) \