| Message ID | 20180105172345.GA31978@embeddedor.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | phylink: mark expected switch fall-throughs in phylink_mii_ioctl | expand |
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com> Date: Fri, 5 Jan 2018 11:23:45 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1463447 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Applied.
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 4e8c459..6ac8b29 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -1525,6 +1525,7 @@ int phylink_mii_ioctl(struct phylink *pl, struct ifreq *ifr, int cmd) switch (cmd) { case SIOCGMIIPHY: mii->phy_id = pl->phydev->mdio.addr; + /* fall through */ case SIOCGMIIREG: ret = phylink_phy_read(pl, mii->phy_id, mii->reg_num); @@ -1547,6 +1548,7 @@ int phylink_mii_ioctl(struct phylink *pl, struct ifreq *ifr, int cmd) switch (cmd) { case SIOCGMIIPHY: mii->phy_id = 0; + /* fall through */ case SIOCGMIIREG: ret = phylink_mii_read(pl, mii->phy_id, mii->reg_num);
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1463447 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> --- This code was compiled with GCC 7.2.0 drivers/net/phy/phylink.c | 2 ++ 1 file changed, 2 insertions(+)