From patchwork Sun Dec 31 18:41:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergei Shtylyov X-Patchwork-Id: 854258 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="K7408SCJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3z8q513Ck8z9s83 for ; Mon, 1 Jan 2018 05:45:09 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751030AbdLaSov (ORCPT ); Sun, 31 Dec 2017 13:44:51 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:36408 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013AbdLaSot (ORCPT ); Sun, 31 Dec 2017 13:44:49 -0500 Received: by mail-lf0-f68.google.com with SMTP id c19so32468948lfg.3 for ; Sun, 31 Dec 2017 10:44:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:user-agent:date:to:subject:mime-version :content-disposition:cc; bh=u8Aq1YYmi/OCqI/goiqNdEFBMDUAWG0ewvQdAJzQHpc=; b=K7408SCJhKscEgorQtvjHU3UHgEInWmyHmgpawQcXi8M9q8BL5BGaJNYggPmSpct1a XMf1hvXIpiKzwLWoHaF9F2BsJcAH6kXuPfXr4he6NPqaqh0mz9W/ESfGKZYFXqp/d4yl rLy1vpXx76iObTSZkefJGqG8TNbJmquXRRDHRdyf2NTlBBftZEiPqiPqNLfLu1lLy4EK Pmz8HsdE7kOR54ZbFONzzqaaiyV+cILaYQX9wbnow7QwCEFS1sE/ebQjgAHfSweRkuEn r97pVDJXwjO/sEMedYfY1fvqWRegU5jLmFx75nkl54zuPNGbfB+XYAw3aCqOFf4Ax/nJ 56SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:user-agent:date:to:subject :mime-version:content-disposition:cc; bh=u8Aq1YYmi/OCqI/goiqNdEFBMDUAWG0ewvQdAJzQHpc=; b=jxChfMCiKBhEfQqQOkkcj2u3W1LZHiHkelUZuA6I0ffrTtWr/2rOZPI3azsP+UgpbT F1KpBTMctmwYS2dwNhoOgQdTSPEl0A2qhKYEaqr5/89n0OxxyQCXla+gyb16GburCE1c r1JtYEkjngrng/eJmomnhfZDsGBMxGrqBaFvPXaU9O1f1pCTp8C65wJrJma2yIJc22Fi l6xDQcrQ8O2LWSzH4kUxy3peMdmvuG1One5o/14oGtgvhe0H7ckuMrdN5rdhgqoTNggX vQUZO3dFgr5PoRTnUovFBa0PXp6vpd9SbIV7kftspfgvFltjYtk9KWioBrKu5V82dTsM a7ig== X-Gm-Message-State: AKGB3mIOSqjJmZjqzZXaHvaTwmFMkkYBnNIxiqyvJZrIywQawpvQiE6B M+i58G6WsJ/dHkti9cNzJaabcF+Z1A4= X-Google-Smtp-Source: ACJfBovHDxzAdzVsLzEX/zSHnHOJzJIEBUlwx4AbOoCyxe+KCbmyt+9cqvToFWnfca4PiVH6iqMj9w== X-Received: by 10.46.85.4 with SMTP id j4mr23764412ljb.137.1514745887796; Sun, 31 Dec 2017 10:44:47 -0800 (PST) Received: from wasted.cogentembedded.com ([31.173.84.49]) by smtp.gmail.com with ESMTPSA id 28sm5026436lfy.96.2017.12.31.10.44.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Dec 2017 10:44:46 -0800 (PST) From: Sergei Shtylyov X-Google-Original-From: "Sergei Shtylyov" Received: by wasted.cogentembedded.com (sSMTP sendmail emulation); Sun, 31 Dec 2017 21:44:44 +0300 Message-Id: <20171231184444.642619406@cogentembedded.com> User-Agent: quilt/0.64 Date: Sun, 31 Dec 2017 21:41:35 +0300 To: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org ("open list:RENESAS ETHERNET DRIVERS") Subject: [PATCH 1/2] ravb: kill redundant check in the probe() method MIME-Version: 1.0 Content-Disposition: inline; filename=ravb-kill-redundant-check-in-the-probe-method.patch Cc: Sergei Shtylyov Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Browsing thru the driver diassembly, I noticed that gcc was able to figure out that the 'ndev' pointer is always non-NULL when calling free_netdev() on the probe() method's error path and thus skip that redundant NULL check... gcc is smart, be like gcc! :-) Signed-off-by: Sergei Shtylyov Reviewed-by: Geert Uytterhoeven --- drivers/net/ethernet/renesas/ravb_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: net-next/drivers/net/ethernet/renesas/ravb_main.c =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/ravb_main.c +++ net-next/drivers/net/ethernet/renesas/ravb_main.c @@ -2205,8 +2205,7 @@ out_dma_free: if (chip_id != RCAR_GEN2) ravb_ptp_stop(ndev); out_release: - if (ndev) - free_netdev(ndev); + free_netdev(ndev); pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev);