Message ID | 20171231161513.25785-3-idosch@mellanox.com |
---|---|
State | RFC, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="C/CdHU2A"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3z8lqf4lZhz9s84 for <patchwork-incoming@ozlabs.org>; Mon, 1 Jan 2018 03:18:22 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751098AbdLaQQe (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Sun, 31 Dec 2017 11:16:34 -0500 Received: from mail-eopbgr30047.outbound.protection.outlook.com ([40.107.3.47]:24032 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751055AbdLaQQb (ORCPT <rfc822;netdev@vger.kernel.org>); Sun, 31 Dec 2017 11:16:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JdJ46YufvU5ah554moEFObJ07FOFPa1BA4KItWHpsr0=; b=C/CdHU2AlWs4wwMh+eGIuqsUi/BpRmVq1CJZslvOuAi4LxtA5vScCbjkz+KwDOw9uarunCdWw+pi+K/0QDvj/dC+BngS7lTH1IbTu7Vea5RFVl2cpoqmxfuAEe/h5g8LYzJefSBajaPu8CLpJeTSOAX8uluZBALCBrKoLJncxHU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; Received: from splinter.mtl.com (193.47.165.251) by AM5PR0501MB2001.eurprd05.prod.outlook.com (2603:10a6:203:1a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.366.8; Sun, 31 Dec 2017 16:16:23 +0000 From: Ido Schimmel <idosch@mellanox.com> To: netdev@vger.kernel.org Cc: davem@davemloft.net, dsahern@gmail.com, roopa@cumulusnetworks.com, nicolas.dichtel@6wind.com, mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com> Subject: [RFC PATCH net-next 02/19] ipv6: Mark dead nexthops with appropriate flags Date: Sun, 31 Dec 2017 18:14:56 +0200 Message-Id: <20171231161513.25785-3-idosch@mellanox.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171231161513.25785-1-idosch@mellanox.com> References: <20171231161513.25785-1-idosch@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM5PR0502CA0020.eurprd05.prod.outlook.com (2603:10a6:203:91::30) To AM5PR0501MB2001.eurprd05.prod.outlook.com (2603:10a6:203:1a::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c084d3ba-7313-4dfd-f7b2-08d55069d613 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(48565401081)(2017052603307)(7153060); SRVR:AM5PR0501MB2001; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2001; 3:x6Cz1cYBWnkHBFCpa6SWnSY4I+wfbxCjh2kFXCuCLgYiUNHt/ISr9qJoZFlLBi37azNGi9qJysQ20zK8UUWRRmxrTp7Ke5omDPMYLFwo3kiIm4rCkto/VSSGg6rcCQLuJPbgpGcv8IOXLYhTaj77X7wNLRHey4r4WgsBgSoS8CBtgqh8RtFGCfX25kbHz0IegHc/rGOLlZqabNAC+lsmqEATX9bWEZXSKzlhlFhyH7K+1yfPaLrdTOI3wDMreu1S; 25:UjNziL1uRK8tTsLmLMdnL4np4PA6gi8zeunPmbAFkoxSEmIsrCVRhxD4ajy4nE1o0mmjEGnCXOC2DeA04U0wmhsh2NFBWt2FajFRNXYmHS352NNy1KYY+WZI+RTLhqPjyRKHH5X07c859K59ULlMiJzvTu7f5GSATSFa3qztraAo28XYYkQuM1M71127gi8jNGvUCY+zc9SEFpAIsaGFWsmFvocHpxbWvEPq4EFlqFCn45nuXRmsoYTEQ00qZaq+p2/RH4G9ZDoCUJ9BRBRiMZB2cMzjXvW2YoghPwdIwdeAD/OhguS4VtBGk1fDUGBYufG/Mtx3VWnR/Y9udJeXgA==; 31:TxqXeruHvDdb42PsHRTT4xmwKlI1sw3p9Us+cXvQxMWYMRODNIJeF0BMC/AHArGXau1GteA8TiHz+9JAMVjQGrgbCupxJLCK19FnOvUcBUaPC3LO+YlBtUfmJQrV/PeH8tFWQRPTkhLLMJP/T7IJLrI7iu3JOyWA9b3TG9meUDdmgCV/BcKYV9CM645oUqnZr1VUZEs6xd0iwxlf9z0arGy/tizB08r5fmcPN05iZXU= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2001: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2001; 20:MbZmPQ8xYt63zzk/acQ94cTjwIc2+eGQcsXG0Ls6ckG6gSpnixRPxyBCyCi8/poQG0RW1qtpoOZprcFVsbPPC/j4MmyUP+NLbSGk61n4JqBPUJivJz3UKjjjhEUbBkwoQUHrxWaEcXgD1Z4CVZJQwHYnic5RK+b654LFju2z+I/eaf+5Fs8X/B0jTY1os75crJvWq3g/Ak5PJBLIjhfctt2K15sHQPFsSecAHcchP732b62XwvVHBBJOEbnPHC2iBioU8BqKwC8xNunoZ3R8R7Fm8N1pFIF7ShLLpOSyq6/WswTggMAugC3usInvRbSISjEYNmf156y2lMZnNJ9EfQnBr8i83DMgE2FcpWGbQ7X0BDMRtg8ry4igJVvrb5JqA6+scPM2J40TP4pqIVZFaejyCmlcA9SwTyyIwbbxare0M4fBUct2CSp+X1b0QxCEYCrGnFPjXMl84FKqhPRl7O9PF1aD+UVkM2TwU/yvvVBnJJuto+IOpIx5tKOvRwKk; 4:RHskSec/KO7m4+gerAYGBS3QG0BcsUvO+/7lEdchF0Fp7LXls79Cgk1Aknp5p1fiAmvqsYret4XgSXQC9KpJixlL3MFgacmkXeAEvBTG1f6cvtT7NI7fL7brsQyUCzVYtWcfEDzUYvqrHl+rRW62DMiN8v0xqEhx8RxDj+KpPBw0w7CR6oDJLaABeABIU8j58gabSwL8xRpyJ2P5+DPuJ18d74aLUedoYu6XrxV7pNa+TW0wn1vustcYkLmHofiWIi47ucqp6NkZkhqIGmH/Wg== X-Microsoft-Antispam-PRVS: <AM5PR0501MB200163C6FFA884961F92B6E2BF1B0@AM5PR0501MB2001.eurprd05.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231023)(944501075)(6055026)(6041268)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:AM5PR0501MB2001; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM5PR0501MB2001; X-Forefront-PRVS: 0538A71254 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(346002)(396003)(39860400002)(376002)(199004)(189003)(106356001)(86362001)(305945005)(6512007)(6486002)(1076002)(316002)(81156014)(2906002)(575784001)(6116002)(3846002)(16526018)(16586007)(8676002)(5660300001)(47776003)(66066001)(25786009)(6916009)(2361001)(39060400002)(68736007)(105586002)(6666003)(36756003)(51416003)(97736004)(48376002)(8936002)(4326008)(52116002)(2351001)(59450400001)(7736002)(53936002)(478600001)(386003)(107886003)(50226002)(50466002)(2950100002)(53416004)(81166006)(76176011)(6506007)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2001; H:splinter.mtl.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2001; 23:O+gmdDepa3S30fHtASQ5Ge4KBn3Ir4L+1szmdl4PHUUSlqoN9YlCUKRmb5PzHUs5h/HhXnk9g9j47LrRWeSaIR417eyQdu4j40JPt9ZZdZbRoDwxJkP4z/1p1Ly9+TA87RerTezzFXsFIoss/sRAG8exHCaq/9evHfgv8HQmRHREzKQiAzq+ywKGH20oCQjnGY/y9HwYeqXste76KB5h3o+qDPJWDCT9TlwCEcyqbUygaA8k+6u8V5DmmvBz2xXYyBqtCuFBYekeHuA6SlO9Gfr82cI8QvooQ/ELBBdrCAZGAHCq6wRYirIXActdT7jl+VPTsyoa0QCA6J1fyj9iSX/k60wj05I0uQ+k8YPNvZxavnBh6vmwluv/dKu2QDD64yKTl00o4D6SPOJDDI+lFM7hvEqh4D6H7wbx+GYZRPfLj9Nd5pBb23f9KH1MX5ZZPq7Nr7TkJIJSurY8QqaE21DtJdGEYuGOfXo2YspIv6tIK7Dsrs6YZgaxrEy3C1fbq/eaUxlxAz3+5N9silFftTUsR5xVfgWOYjMvWQFPttqNe2racB1omLjySLtrDHPkeFWlOWSdyFzP3H9hJ5qq7hJjlBlyo0GJESrK8k6dUh5DLpeMAdcfp0MFJiVZ7EkbOflzpLNLJeyLLU5SGij1sHWRp0vp7OiwUKHjONt03abGaENY5aFBEDdnsVuwXVSbHezQk7Jsj9X4PmJO3JhmXjYkWEHuX82t5ReMRji0t9VT0pzGMrq+4GhyqeQzRIEc6JWiCTMAsknpPx85eFtd5S1qMbtI2NFNFdHepDA+L5SqJc1dMQ6pzzZu/EzpMw3vwPNF198q1dZ9ie0GaQrUgRFSuC/o727lrPpEb3Gdt/DPWIhrIz9vNeEEXldf2c7td/SpKDJ/wRxwlqOjo6qAYa4VG60KYjPdw+UQURleDiCVg7nNMsI8HBLqX1rr9x1GflFOS3YtjJbxjj2HiDwqT/OPXBLkkwX95uv0iJD1NrhXNUIc7kHMidhuYixMpmHIAURj7ne0b2sCZcSTiR7SJY+7RJntvbdk4cHOgywDfYN+E4hnS1p+F3ITuM0AFWGyJEQsmYXjWpEVFT9EihHWKeD7cgGbeLehNJS4NHr3RXORP6qNU6AqHUmiLc5VdlUc/gwibgxO1lnmAtPKHDPC542o50RKT2N8LncWlpnLuP9wPW8ADrZFEOP50+yIeHoL4sXQRglfBIZ+srOxqAjLale/N9yozWJiXUSOJV6mSGbY6REN14Pt2oZCKEapncrr X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2001; 6:R9Ut0FeThfRD6vOdcm6sYHktdh+E6/d1rmeFa8y9qPxdeavqDRAm68kWg7IQEK78QZ0LWf+DlcVh7O9wj6ZdcQXU/R9w3cpC4rwY+DSh9fVfsw6jk+kuknxMuE4musqTUqJ/pWUko0ORJziIBSMpl7tb7CVNrfOEv+DhQvpVcgOFeBG67nSbyVCOPvpHgylB3I4d0UNRIOyAJjTdQCk7YrLgkMsMnVkrXRiG+yGufzaOD3KZgtvNj47S0HVHihX0RiYiDmeMoQU+jCm/yilwxLD5E3mxZHkHFa2I5IQKJFWlVy1EbSNqMjorqL01xQBkGdPFTMO1UFnT2I2xKoi24rEeMJT1R/9R1VriblQ6Os4=; 5:JlW4jR3e42qp9uNeYpyy+Ls2H4l+zJqVztODLhu5M6WXhL51bi5Iqkq57rjUp3JeLNTjGsEa0bnieclLkjEVw4/I0C8v57c7XHyyXfLOuCFhZUVdO5+vG6QpfkKTIIQk58xBcHjqrzJuDeVPeZx3W/ScExL1xhnSH6eXpnnv8bo=; 24:LW5v+vKsUbL5qn7Bl/ClTPNSmkPSF9jZmtx/jZ9l7F8NsG9yX+TmZb6JPKpCn9G897q/JBjSqwoYVZhQGXIFEoSat1sB84dPTnZZXIcr8IY=; 7:/TbLLw7FjG2eQeSUaqCwxFleX8bR5RlCrlrzpP+Nv40qzUiSYIs10Wp61AkIY0QXPphqhXstqUPhl6VyjXlgbiFR8XEta4O7wwp/l5kjNRJYsRtxvuh2iTTNXcTapX6keeUmopeuNRp0hYdcMJQSlQM877B22cVZu+i3ch4U9ZZmTZ6P33NBDmHM8p8cJ8rPIbX1vyoZgZmnPFxMEQbfOmMzYknTBev9zAVO/E9qqVspPBPmXmNVKYPa3eSegJHP SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2017 16:16:23.0432 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c084d3ba-7313-4dfd-f7b2-08d55069d613 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2001 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series |
[RFC,net-next,01/19] ipv6: Remove redundant route flushing during namespace dismantle
|
expand
|
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index c557362daa23..f5eda0aeab55 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -3473,8 +3473,10 @@ static int fib6_ifdown(struct rt6_info *rt, void *arg) if (rt->dst.dev == dev && rt != adn->net->ipv6.ip6_null_entry && (rt->rt6i_nsiblings == 0 || netdev_unregistering(dev) || - !rt->rt6i_idev->cnf.ignore_routes_with_linkdown)) + !rt->rt6i_idev->cnf.ignore_routes_with_linkdown)) { + rt->rt6i_nh_flags |= (RTNH_F_DEAD | RTNH_F_LINKDOWN); return -1; + } return 0; }
When a netdev is put administratively down or unregistered all the nexthops using it as their nexthop device should be marked with the 'dead' and 'linkdown' flags. Currently, when a route is dumped its nexthop device is tested and the flags are set accordingly. A similar check is performed during route lookup. Instead, we can simply mark the nexthops based on netdev events and avoid checking the netdev's state during route dump and lookup. Signed-off-by: Ido Schimmel <idosch@mellanox.com> --- net/ipv6/route.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)