| Message ID | 20171229190545.21109-1-f.fainelli@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: dsa: Fix dsa_legacy_register() return value | expand |
From: Florian Fainelli <f.fainelli@gmail.com> Date: Fri, 29 Dec 2017 11:05:45 -0800 > We need to make the dsa_legacy_register() stub return 0 in order for > dsa_init_module() to successfully register and continue registering the > ETH_P_XDSA packet handler. > > Fixes: 2a93c1a3651f ("net: dsa: Allow compiling out legacy support") > Reported-by: Egil Hjelmeland <privat@egil-hjelmeland.no> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Applied, thanks Florian.
diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h index b03665e8fb4e..cefb0c3c6d51 100644 --- a/net/dsa/dsa_priv.h +++ b/net/dsa/dsa_priv.h @@ -103,7 +103,7 @@ void dsa_legacy_unregister(void); #else static inline int dsa_legacy_register(void) { - return -ENODEV; + return 0; } static inline void dsa_legacy_unregister(void) { }
We need to make the dsa_legacy_register() stub return 0 in order for dsa_init_module() to successfully register and continue registering the ETH_P_XDSA packet handler. Fixes: 2a93c1a3651f ("net: dsa: Allow compiling out legacy support") Reported-by: Egil Hjelmeland <privat@egil-hjelmeland.no> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- net/dsa/dsa_priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)